Skip to content

Conversation

@drguthals
Copy link
Contributor

Separating the Dev/Staging recommendations from the Production recommendations on conditionally including the Dev Toolbar.

The code for conditionally including in the Production environment is so dependent on the application, we should have them be separate.

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 4:55pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 4:55pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 4:55pm

@drguthals drguthals marked this pull request as ready for review December 18, 2024 17:04
@drguthals drguthals merged commit 7846e43 into master Dec 18, 2024
10 checks passed
@drguthals drguthals deleted the update-dev-toolbar branch December 18, 2024 17:05
@codecov
Copy link

codecov bot commented Dec 18, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.35MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️

@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants