Clarify that tree shaking replay worker is optional #12261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
coolguyzone
reviewed
Jan 7, 2025
docs/platforms/javascript/common/session-replay/configuration.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
approved these changes
Jan 7, 2025
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the clarification 🤙
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
We had a comment that it was unclear whether the tree shaking step when adding a custom worker script for replay was optional.
getsentry/sentry-javascript#14794 (reply in thread)
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.