feat(flags): re-publish docs on python unleash and generic integrations #12300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 261 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
coolguyzone
reviewed
Jan 10, 2025
| @@ -0,0 +1,49 @@ | |||
| --- | |||
| title: Generic | |||
Contributor
There was a problem hiding this comment.
Could we make the title a little more descriptive here? Like 'Generic Feature Flags' or something like that? Same with the page title for 'Unleash', maybe 'Feature Flags using Unleash'?
cmanallen
previously requested changes
Jan 13, 2025
Member
cmanallen
left a comment
cmanallen
left a comment
There was a problem hiding this comment.
Move generic integration documentation to platform/<language>/feature-flags since the generic integration is going away. Ref: getsentry/sentry-python#3917
…o revert-12296-aliu/unpublish-unleash
antonpirker
approved these changes
Jan 14, 2025
Contributor
antonpirker
left a comment
antonpirker
left a comment
There was a problem hiding this comment.
Made some smaller changes to push this over the finish line.
aliu39
commented
Jan 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These docs were originally approved and published, but reverted in #12296 since the integrations aren't released, and won't be for at least a couple days.
This PR re-publishes them and
initialize_client()) and versioning.flagscontext into Scope sentry-python#3917Closes https://github.com/getsentry/team-replay/issues/516