feat: Drop success and danger Alert levels
#12418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not use success at all, and danger only in few places, where we can also use `warning` instead.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 354 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
|
I would actually keep these tbh, or was this a requirement to drop these with the new design? |
|
IMHO we are not using success and I would not know when to use it, and danger, how we use it, is not really different from warning 🤔 I am always in favor of removing stuff that is not needed and possibly adding it back if we actually have a good case for it. Makes it easier to use stuff as there is less paralysis of choice 😅 |
chargome
approved these changes
Jan 22, 2025
|
@mydea Just saw that @inventarSarah was making use of "success" in #12291, would you mind reverting? 😭 |
|
I will re-add success here then: #12422! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not use success at all, and danger only in few places, where we can also use
warninginstead.