docs(self-hosted): handle reverse proxy cors issues for ingest endpoints #12513
Conversation
|
@aldy505 is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
Can I get your eyes on this? @hubertdeng123 @bc-sentry |
| proxy_buffer_size 128k; | ||
| proxy_buffers 4 256k; | ||
| # Handle CORS-related headers for ingest endpoints. |
There was a problem hiding this comment.
Why is this necessary? It would be helpful to understand why these changes are being made to see if this is indicative of a larger issue, especially since it's not something common we've seen
There was a problem hiding this comment.
Linking the discord thread could give helpful context
There was a problem hiding this comment.
AFAIK it was this: https://discord.com/channels/621778831602221064/1334066733752909855
Oh, also here, by myself: https://discord.com/channels/621778831602221064/796028405833007104/1169197966460985395
hubertdeng123
left a comment
hubertdeng123
left a comment
There was a problem hiding this comment.
Seems fine with me, and this are experimental docs after all and can be updated
|
@aldy505 can you please force push to this PR? I cannot get the build to render a preview, and I want to give it a once-over before merging. Thanks! |
…ndle-reverse-proxy-cors
|
@sfanahata Done! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
sfanahata
left a comment
sfanahata
left a comment
There was a problem hiding this comment.
Looks good! The preview and changes render just fine.
…nts (#12513) <!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Someone on Discord pointed out that they had CORS issues from the browser when submitting events to Sentry. This patch is to make sure that would never happen. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
3 participants
DESCRIBE YOUR PR
Someone on Discord pointed out that they had CORS issues from the browser when submitting events to Sentry. This patch is to make sure that would never happen.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES