Skip to content

Conversation

@szokeasaurusrex
Copy link
Member

Previously, any nested lists would be rendered as follows:

1. Main item
   1. Sub-item
      1. Sub-sub-item
      2. Another sub-sub-item
   2. Another sub-item
2. Another main item

Reading the above nested list is difficult, since the reader needs to keep track of the indentation in order to tell whether an item is a main item, sub-item, or sub-sub-item.

This PR changes the numbering format for sub-items and sub-sub-items to make the item types clearer. The example above would now render as:

1. Main item
   a. Sub-item
      i. Sub-sub-item
      ii. Another sub-sub-item
   b. Another sub-item
2. Another main item

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Previously, any nested lists would be rendered as follows:

```
1. Main item
   1. Sub-item
      1. Sub-sub-item
      2. Another sub-sub-item
   2. Another sub-item
2. Another main item
```

Reading the above nested list is difficult, since the reader needs to keep track of the indentation in order to tell whether an item is a main item, sub-item, or sub-sub-item.

This PR changes the numbering format for sub-items and sub-sub-items to make the item types clearer. The example above would now render as:

```
1. Main item
   a. Sub-item
      i. Sub-sub-item
      ii. Another sub-sub-item
   b. Another sub-item
2. Another main item
```
@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:07pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:07pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 3:07pm

@codecov
Copy link

codecov bot commented Feb 5, 2025

Bundle Report

Changes will increase total bundle size by 70 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.7MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.38MB 79 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 866.04kB -0.0%
static/css/*.css 85 bytes 8.66kB 0.99%
static/chunks/9557-*.js -3 bytes 391.11kB -0.0%
static/yokPS1ebSQvY0778CKA1M/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/yokPS1ebSQvY0778CKA1M/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/FS3UTQ6EILMgwPan8xJLw/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/FS3UTQ6EILMgwPan8xJLw/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.63MB -0.0%
../instrumentation.js -3 bytes 965.23kB -0.0%
9523.js -3 bytes 941.45kB -0.0%

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better this way, thanks for adding!

@szokeasaurusrex szokeasaurusrex merged commit 925b175 into master Feb 5, 2025
11 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/sample_rand-numbering branch February 5, 2025 15:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants