docs(rust-sdk): refactor config options page #12625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
coolguyzone
reviewed
Feb 10, 2025
coolguyzone
reviewed
Feb 10, 2025
coolguyzone
reviewed
Feb 10, 2025
coolguyzone
approved these changes
Feb 10, 2025
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Thanks for updating! Looks much easier to navigate now 🏄♂️
lcian
approved these changes
Feb 12, 2025
Member
lcian
left a comment
lcian
left a comment
There was a problem hiding this comment.
I think we can keep the rest of the types as is to keep it high level and not create too much noise with complex types, people can always consult the API docs for that
Co-authored-by: Lorenzo Cian <lorenzo.cian@sentry.io> Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Contributor
Author
|
Thank you both, @lcian and @coolguyzone for your thorough review 🙏 Added all your suggestions 💯 |
a-hariti
pushed a commit
that referenced
this pull request
Feb 12, 2025
Co-authored-by: Lorenzo Cian <lorenzo.cian@sentry.io> Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.