Skip to content

Conversation

@adinauer
Copy link
Member

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:36am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Feb 17, 2025 7:36am
develop-docs ⬜️ Ignored (Inspect) Feb 17, 2025 7:36am

@codecov
Copy link

codecov bot commented Feb 17, 2025

Bundle Report

Bundle size has no change ✅

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/b1IEZfemHYUSDHh9x4NHO/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/b1IEZfemHYUSDHh9x4NHO/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/_xcJ-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/_xcJ-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

caseStyle: camelCase
supportLevel: production
sdk: sentry.java.jul
categories:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added these in the hope that it'd show the config options env var for platform guides like Spring Boot but it didn't. This should however still be here I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know this is inherited from the platform (java)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK, can remove it again then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this again, just inheriting would be wrong here since some are not meant for desktop. So I think we should keep them the way they are in this PR.

</SdkOption>

## Integration Configuration
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have been copied from generic docs and doesn't work this way in Java SDK so I removed it.

@stephanie-anderson stephanie-anderson merged commit f571e62 into config-options-java Mar 6, 2025
6 checks passed
@stephanie-anderson stephanie-anderson deleted the feat/config-options-java-env branch March 6, 2025 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants