Skip to content

Conversation

@codyde
Copy link
Contributor

@codyde codyde commented Feb 19, 2025

DESCRIBE YOUR PR

Refactoring of tracing docs within JavaScript to provide additional clarity on distributed tracing, span metrics, and configuring custom spans. This PR includes changes to the nav structure, and introduces a new nav that will be replicated across other SDKs once we've finished reviewing the potential changes.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Other deadline: 2/28

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 7:41am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 7:41am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 7:41am

@codecov
Copy link

codecov bot commented Feb 19, 2025

Bundle Report

Changes will increase total bundle size by 4.46kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.54MB 4.47kB (0.04%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.57MB -0.0%
../instrumentation.js -3 bytes 904.32kB -0.0%
9523.js -3 bytes 880.37kB -0.0%
../app/[[...path]]/page.js.nft.json 1.49kB 379.91kB 0.39%
../app/platform-redirect/page.js.nft.json 1.49kB 379.83kB 0.39%
../app/sitemap.xml/route.js.nft.json 1.49kB 377.8kB 0.4%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.16kB -0.0%
static/chunks/3319-*.js -3 bytes 393.41kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/oxEs0s0zFcQPtcsO9ylY0/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/oxEs0s0zFcQPtcsO9ylY0/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/XY7or7GbPDoFLHB89C6n0/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/XY7or7GbPDoFLHB89C6n0/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
codyde and others added 4 commits March 11, 2025 13:17
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 🛳️

Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
codyde added 2 commits March 13, 2025 00:26
…om/getsentry/sentry-docs into codyde/javascript-tracing-refactor

* 'codyde/javascript-tracing-refactor' of https://github.com/getsentry/sentry-docs: (104 commits)
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update index.mdx (#12928)
  docs(self-hosted): monitor self-hosted instance (#12660)
  fix(feedback): rm per-feedback attach limit (#12968)
  fix(404): php integrations (#12966)
  docs(js): Update stale reference (#12964)
  fix(solidstart): Remove outdated `sentrySolidStartVite` option (#12962)
  chore(sandbox): change sandbox link (#12814)
  feat: Godot debug symbols guide (#12843)
  fix 404s (#12961)
  Fix SDK getting started pages (onboarding options) (#12960)
  fix(platform): Update onboarding options on tab switch (#12913)
  Fix Apollo links (#12952)
  chore(Android): Update docs to match actual SDK behavior (#12954)
  docs(js): Add example docs for non-HTTP protocols (#12933)
  ...
@codyde codyde merged commit 4c4d7de into master Mar 13, 2025
13 checks passed
@codyde codyde deleted the codyde/javascript-tracing-refactor branch March 13, 2025 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants