Skip to content

Conversation

@jas-kas
Copy link
Member

@jas-kas jas-kas commented Feb 19, 2025

Part of #12776

@vercel
Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 7:29pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 7:29pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 7:29pm

@jas-kas jas-kas requested review from billyvg and ryan953 February 19, 2025 15:35
---

[Issues](/product/issues/) are an aggregate of one or more error events. Searchable issues properties include status, assignment, aggregate counts, and age. You can search by issue properties in the **Issues** page and in **Dashboards** in the widget builder, depending on your dataset selection.
[Issues](/product/issues/) are an aggregate of one or more error events. Searchable issues properties include status, assignment, aggregate counts, and age. Also, if you have set up [evlauation tracking for feature flags](/product/issues/issue-details/feature-flags/#evaluation-tracking), you can search for issues that have error events where the feature flag evaluated value is `true` or `false`. You can search by issue properties in the **Issues** page and in **Dashboards** in the widget builder, depending on your dataset selection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Issues](/product/issues/) are an aggregate of one or more error events. Searchable issues properties include status, assignment, aggregate counts, and age. Also, if you have set up [evlauation tracking for feature flags](/product/issues/issue-details/feature-flags/#evaluation-tracking), you can search for issues that have error events where the feature flag evaluated value is `true` or `false`. You can search by issue properties in the **Issues** page and in **Dashboards** in the widget builder, depending on your dataset selection.
[Issues](/product/issues/) are an aggregate of one or more error events. Searchable issues properties include status, assignment, aggregate counts, and age. You can search by issue properties in the **Issues** page and in **Dashboards** in the widget builder, depending on your dataset selection. If you have set up [evaluation tracking for feature flags](/product/issues/issue-details/feature-flags/#evaluation-tracking), you can search for issues that have error events where the feature flag evaluated value is `true` or `false`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah. flag isn't even in the table.

Maybe instead of an extra sentence here, we should be putting it in the table and linking from there out to the setup docs. This seems to be how transaction is setup for example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not an OOTB search we have within Issues (set up is required and even then, flag names are specific to the organization) so it wasn't clear how it would fit in the below table IMO. BUT the transaction pattern is a good one to follow, will modify this PR

@codecov
Copy link

codecov bot commented Feb 19, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/DHpOm8rKnwqZrIUL058et/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/DHpOm8rKnwqZrIUL058et/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/kdSpaPexceeLxvb677q9o/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/kdSpaPexceeLxvb677q9o/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%

@jas-kas jas-kas requested a review from ryan953 February 19, 2025 16:55
Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
---

[Issues](/product/issues/) are an aggregate of one or more error events. Searchable issues properties include status, assignment, aggregate counts, and age. You can search by issue properties in the **Issues** page and in **Dashboards** in the widget builder, depending on your dataset selection.
[Issues](/product/issues/) are an aggregate of one or more error events. Searchable issues properties include status, assignment, aggregate counts, and age. If you have set up [evaluation tracking for feature flags](/product/issues/issue-details/feature-flags/#evaluation-tracking), you can search for issues that have error events where the feature flag evaluated value is `true` or `false`. You can search by issue properties in the **Issues** page and in **Dashboards** in the widget builder, depending on your dataset selection.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Issues](/product/issues/) are an aggregate of one or more error events. Searchable issues properties include status, assignment, aggregate counts, and age. If you have set up [evaluation tracking for feature flags](/product/issues/issue-details/feature-flags/#evaluation-tracking), you can search for issues that have error events where the feature flag evaluated value is `true` or `false`. You can search by issue properties in the **Issues** page and in **Dashboards** in the widget builder, depending on your dataset selection.
[Issues](/product/issues/) are an aggregate of one or more error events. Searchable issues properties include status, assignment, aggregate counts, and age. If you have set up [evaluation tracking for feature flags](/product/issues/issue-details/feature-flags/#evaluation-tracking), you can search for issues that have error events where the feature flag evaluated value is `true` or `false`. You can search by issue properties in the **Issues** page and in **Dashboards** in the widget builder, depending on your dataset selection.

@jas-kas jas-kas enabled auto-merge (squash) February 19, 2025 19:28
@jas-kas jas-kas merged commit 24a47b3 into master Feb 19, 2025
11 checks passed
@jas-kas jas-kas deleted the jas-kas-ff-search branch February 19, 2025 19:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants