Skip to content

Conversation

@chargome
Copy link
Member

Clarifies that beforeErrorSampling is only triggered in buffer mode.

closes getsentry/sentry-javascript#15470

@chargome chargome self-assigned this Feb 24, 2025
@vercel
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 5:50pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Feb 24, 2025 5:50pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 5:50pm

@chargome chargome requested a review from billyvg February 24, 2025 17:38
@codecov
Copy link

codecov bot commented Feb 24, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.95MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/QS_N6tMDDQ7zJbLEXwVQZ/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/QS_N6tMDDQ7zJbLEXwVQZ/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/HpBC4zdUWf-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/HpBC4zdUWf-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️

@chargome chargome merged commit 6af20c1 into master Feb 25, 2025
11 checks passed
@chargome chargome deleted the cg/clarify-replay-hook branch February 25, 2025 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: Clarify ReplayIntegration with beforeErrorSampling in session / buffer mode

4 participants