Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Mar 3, 2025

DESCRIBE YOUR PR

Users sometimes commit their auth tokens because the docs don't communicate that this is something that should be kept secret.

While we have warnings about not committing the token in our wizard here, there is no warning when just following the docs.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@s1gr1d s1gr1d requested a review from chargome March 3, 2025 13:30
@vercel
Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 2:00pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 2:00pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 3, 2025 2:00pm

@s1gr1d s1gr1d self-assigned this Mar 3, 2025
@codecov
Copy link

codecov bot commented Mar 3, 2025

Bundle Report

Changes will increase total bundle size by 229 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.2MB 113 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.39MB 116 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.04kB -0.0%
static/chunks/4028-*.js -3 bytes 393.29kB -0.0%
static/chunks/app/[[...path]]/page-*.js 122 bytes 73.14kB 0.17%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/jTgnyz6iVz2JW3i_WxNOD/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/jTgnyz6iVz2JW3i_WxNOD/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/k8ujUP5XL1aiDc36MO9J-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/k8ujUP5XL1aiDc36MO9J-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/app/[[...path]]/page-*.js:

  • ./src/components/orgAuthTokenNote.tsx → Total Size: 4.38kB
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.46MB -0.0%
../instrumentation.js -3 bytes 791.26kB -0.0%
9523.js -3 bytes 767.46kB -0.0%
../app/[[...path]]/page.js 122 bytes 530.85kB 0.02%

Files in ../app/[[...path]]/page.js:

  • ./src/components/orgAuthTokenNote.tsx → Total Size: 4.1kB

  • ./src/components/orgAuthTokenNote.tsx → Total Size: 896 bytes

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 122 bytes 3.08MB 0.0%

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@s1gr1d s1gr1d merged commit 4309749 into master Mar 3, 2025
13 checks passed
@s1gr1d s1gr1d deleted the sig/auth-token-notice branch March 3, 2025 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants