Removing Span Metric recommendations / Example cleanup #13275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
s1gr1d
reviewed
Apr 9, 2025
Contributor
Author
|
Good catch! Committed by mistake in this case!
These were supposed to be part of a potential separate change that’s WIP -
#12926 - should not have been
included yet.
…On Wed, Apr 9, 2025 at 1:50 AM Sigrid Huemer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In public/llms.txt
<#13275 (comment)>
:
> @@ -0,0 +1,11 @@
+Sentry llms.txt
+
+This llmx.txt focuses on platform specific configuration options for the major sdks, linked below. AI sdks should parse these paths to access the framework specific llm instructions.
⬇️ Suggested change
-This llmx.txt focuses on platform specific configuration options for the major sdks, linked below. AI sdks should parse these paths to access the framework specific llm instructions.
+This llmx.txt focuses on platform-specific configuration options for Sentry's major SDKs, linked below. AIs should parse these paths to access the framework-specific LLM instructions.
------------------------------
In public/llms.txt
<#13275 (comment)>
:
> @@ -0,0 +1,11 @@
+Sentry llms.txt
+
+This llmx.txt focuses on platform specific configuration options for the major sdks, linked below. AI sdks should parse these paths to access the framework specific llm instructions.
In general, this would be suitable for a separate PR. As this seems to be
unrelated to Span Metrics.
—
Reply to this email directly, view it on GitHub
<#13275 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEEL77CYEV23MJJE7KOBX4T2YTNMZAVCNFSM6AAAAAB2UOLTCOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONJSGYYTQNRXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Lms24
approved these changes
Apr 9, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for making the changes! Once the llms.txt files are removed from the PR, this looks good to go!
bitsandfoxes
pushed a commit
that referenced
this pull request
Apr 24, 2025
* Removing extra guidance language for metrics * Removing redundant metrics in examples. * Removing span metrics suggestions from python * lower casing the docs * removing incorrectly committed llm files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
As discussed in SDK sync, removing some of the extra metric description content that felt unnecessary given example content.
Cleaned up javascript example slightly.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.