Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Apr 11, 2025

DESCRIBE YOUR PR

We already have extensive docs about both under Enriching Events > Scopes / Breadcrumbs.
This is only taking up space in the already large sidebar.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 7:10pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 7:10pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) May 6, 2025 7:10pm

@lcian lcian requested a review from adinauer April 11, 2025 12:23
@codecov
Copy link

codecov bot commented Apr 11, 2025

Bundle Report

Changes will decrease total bundle size by 186 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.16MB -180 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.48MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json -57 bytes 391.29kB -0.01%
../app/platform-redirect/page.js.nft.json -57 bytes 391.21kB -0.01%
../app/sitemap.xml/route.js.nft.json -57 bytes 389.18kB -0.01%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/WQ95KDndwnIU-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/WQ95KDndwnIU-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/ZGbj5L1F_EgGGxCJZqL3f/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/ZGbj5L1F_EgGGxCJZqL3f/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the page from sidebar and forward to https://docs.sentry.io/platforms/java/enriching-events/ ?

Ideally a platform specific redirect.

@lcian
Copy link
Member Author

lcian commented Apr 16, 2025

Can we remove the page from sidebar and forward to docs.sentry.io/platforms/java/enriching-events ?

Ideally a platform specific redirect.

Ah you're right we need to do that, otherwise if someone finds a link to this page they will encounter a 404.

@lcian lcian enabled auto-merge (squash) May 6, 2025 18:47
@lcian lcian merged commit 27a610e into master May 6, 2025
12 of 13 checks passed
@lcian lcian deleted the lcian/patch-1 branch May 6, 2025 19:10
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants