Skip to content

Conversation

@Flash0ver
Copy link
Member

@Flash0ver Flash0ver commented Apr 16, 2025

DESCRIBE YOUR PR

Add SendDefaultPii = true option to .NET SDKs.
See getsentry/team-sdks#121.

Follow-up: #13416

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.):
  • Other deadline: 2025-04-16
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 6:18pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Apr 16, 2025 6:18pm
develop-docs ⬜️ Ignored (Inspect) Apr 16, 2025 6:18pm

@codecov
Copy link

codecov bot commented Apr 16, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/HyS422G7ehhcCcb4jR-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/HyS422G7ehhcCcb4jR-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/z7M1pyEg4WdshFcTN8C0q/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/z7M1pyEg4WdshFcTN8C0q/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

@Flash0ver Flash0ver changed the title Docs/dotnet/senddefaultpii true docs(dotnet): Add SendDefaultPii = true option Apr 16, 2025
</Alert>

```csharp {"onboardingOptions": {"performance": "11-13"}}
```csharp {"onboardingOptions": {"performance": "13-15"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, to also take care of these line numbers!

Copy link
Contributor

@stephanie-anderson stephanie-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

.Dsn = "___PUBLIC_DSN___",

' Adds request URL and headers, IP and name for users, etc.
.SendDefaultPii = True,
Copy link
Member Author

@Flash0ver Flash0ver Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Both Visual Basic With Statements don't look quite right. I will follow up with a non-urgent PR to revise these.

@stephanie-anderson stephanie-anderson merged commit 57a9f62 into master Apr 16, 2025
15 checks passed
@stephanie-anderson stephanie-anderson deleted the docs/dotnet/senddefaultpii-true branch April 16, 2025 19:22
codyde added a commit that referenced this pull request Apr 19, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (131 commits)
  refactor: migrate Golang and related guides to inline product options syntax (#13413)
  refactor: migrate DotNet sdks to inline product options syntax (#13415)
  add note of the switch sdk (#13431)
  Update spelling in examples.mdx (#13378)
  ref(replay): clarify web & mobile distinction in product docs (#13447)
  fix(java): fix `RestTemplate` auto-instrumentation guide (#13236)
  refactor: migrate Python and related guides to inline product options syntax (#13412)
  Unreal: Document and add `SendDefaultPii = true` to onboarding docs (#13435)
  docs(tracing): Add docs for Previous and Next trace (#13406)
  docs(js): Create Svelte Quick Start guide (#13387)
  Update Profiling SDK version number for iOS/macOS (#13429)
  remove note that workflow notifications alert on new feedback (#13384)
  fix(dart): 404 link (#13430)
  feat(Godot): Update options screenshot on the landing page (#13428)
  add senddefaultpii to powershell (#13426)
  powershell senddefaultpii landing page (#13427)
  chore: update powershell min version requirement (#13425)
  docs(replays): add count_traces to searchable properties (#13422)
  docs(js): Add `sendDefaultPii: true` to all init calls (#13408)
  docs(dotnet): Add `SendDefaultPii = true` option (#13423)
  ...
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
* docs(dotnet): add "Data Collected" page

* docs(dotnet): add SendDefaultPii option

* Revert "docs(dotnet): add "Data Collected" page"

This reverts commit 7b761e5.
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants