Skip to content

Conversation

@antonpirker
Copy link
Contributor

DESCRIBE YOUR PR

The option is called traces_sampler (or tracesSampler) thus we should use same (plural form) name everywhere.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 11:21am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2025 11:21am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2025 11:21am

@antonpirker antonpirker marked this pull request as ready for review April 22, 2025 10:54
@antonpirker antonpirker enabled auto-merge (squash) April 22, 2025 10:55
@antonpirker antonpirker requested review from codyde and sfanahata April 22, 2025 10:55
@codecov
Copy link

codecov bot commented Apr 22, 2025

Bundle Report

Changes will increase total bundle size by 12 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB 18 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 9 bytes 388.44kB 0.0%
../app/platform-redirect/page.js.nft.json 9 bytes 388.35kB 0.0%
../app/sitemap.xml/route.js.nft.json 9 bytes 386.32kB 0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/zYOyQsrgfmlCwMJPMR_rr/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/zYOyQsrgfmlCwMJPMR_rr/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/vKvghiMny1JEDIMb9eCO4/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/vKvghiMny1JEDIMb9eCO4/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@coolguyzone
Copy link
Contributor

Hey @antonpirker just confirming, in the product is the option always traces_sampler? Meaning that everywhere we list trace_sampler, the code will create an error if the user copies the example?

@coolguyzone coolguyzone self-requested a review April 22, 2025 22:40
Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Looks right. I'm confused as to why there are so many docs that don't actually appear to have a real diff?

@antonpirker antonpirker merged commit 997f8cd into master Apr 23, 2025
15 checks passed
@antonpirker antonpirker deleted the antonpirker/naming-traces-sampler branch April 23, 2025 21:35
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants