Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 22, 2025

⚠️ This is ready for review but only to be merged after the Angular Wizard was released!

DESCRIBE YOUR PR

This PR replaces our previous "Getting Started" in our Angular guide with two new pages:

  • The "Quick Start" page recommending the brand new Angular wizard setup
  • A "Manual Setup" page for anyone who can't or doesn't want to use the wizard

Both pages are heavily inspired by @inventarSarah's "Quick Start" work in other guides, featuring the numbered steps, making use of expandables and expanding on the verification steps.

I removed a couple of PlatformContent includes because a) I hate looking them up and b) they were unnecessary b/c we only showed the contents on one page anyway. The content now lives directly in the "Manual Setup" page.
I also adjusted code highlights a bit where they were off after our recent migration to the comment-based delimiters for feature code.

closes getsentry/sentry-wizard#672

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 0:26am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 0:26am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 0:26am

@Lms24 Lms24 self-assigned this Apr 22, 2025
@Lms24 Lms24 requested a review from s1gr1d April 22, 2025 13:57
@codecov
Copy link

codecov bot commented Apr 22, 2025

Bundle Report

Changes will decrease total bundle size by 267 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -261 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json -84 bytes 388.34kB -0.02%
../app/platform-redirect/page.js.nft.json -84 bytes 388.26kB -0.02%
../app/sitemap.xml/route.js.nft.json -84 bytes 386.23kB -0.02%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/4iubNlx6hW8E3tifG8gWW/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/4iubNlx6hW8E3tifG8gWW/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/QvrOwIj67vseYOd0FTOYr/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/QvrOwIj67vseYOd0FTOYr/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Collaborator

@inventarSarah inventarSarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lukas, great work 🎉

I have added some suggestions, mainly to improve consistency with our other guides.

Co-authored-by: Sarah Mischinger <sarah@codingwriter.com>
@Lms24
Copy link
Member Author

Lms24 commented Apr 23, 2025

Thanks for the great review @inventarSarah!

@Lms24 Lms24 merged commit 3702c8a into master Apr 23, 2025
15 checks passed
@Lms24 Lms24 deleted the lms/feat-angular-wizard branch April 23, 2025 13:05
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
…Manual Setup pages (#13472)

---------

Co-authored-by: Sarah Mischinger <sarah@codingwriter.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Wizard for Angular

4 participants