-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(angular): Replace "Getting Started" with Wizard Quick Start and Manual Setup pages #13472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Manual Setup pages
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 267 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
inventarSarah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lukas, great work 🎉
I have added some suggestions, mainly to improve consistency with our other guides.
Co-authored-by: Sarah Mischinger <sarah@codingwriter.com>
|
Thanks for the great review @inventarSarah! |
…Manual Setup pages (#13472) --------- Co-authored-by: Sarah Mischinger <sarah@codingwriter.com>
DESCRIBE YOUR PR
This PR replaces our previous "Getting Started" in our Angular guide with two new pages:
Both pages are heavily inspired by @inventarSarah's "Quick Start" work in other guides, featuring the numbered steps, making use of expandables and expanding on the verification steps.
I removed a couple of
PlatformContentincludes because a) I hate looking them up and b) they were unnecessary b/c we only showed the contents on one page anyway. The content now lives directly in the "Manual Setup" page.I also adjusted code highlights a bit where they were off after our recent migration to the comment-based delimiters for feature code.
closes getsentry/sentry-wizard#672
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES