Skip to content

Conversation

@JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented May 7, 2025

Relevant vercel preview pages

DESCRIBE YOUR PR

Related to the change in getsentry/sentry-native#1228

From now on, we provide the sentry_value_new_user(id, username, email, ip_address) function that fills out the correct keys. This should reduce user error & confusion with what keys are processed by Sentry (see the original issue the function was added for).

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 3:46pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 7, 2025 3:46pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2025 3:46pm

@codecov
Copy link

codecov bot commented May 7, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.16MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.48MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/lr-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/lr-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/_Pc8bC8BrCpPyn2C51k7G/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/_Pc8bC8BrCpPyn2C51k7G/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@JoshuaMoelans JoshuaMoelans marked this pull request as ready for review May 7, 2025 14:56
@JoshuaMoelans JoshuaMoelans requested a review from supervacuus May 7, 2025 14:56
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
@JoshuaMoelans JoshuaMoelans merged commit 2444b8f into master May 7, 2025
11 checks passed
@JoshuaMoelans JoshuaMoelans deleted the joshua/native/new_user_function branch May 7, 2025 15:48
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants