-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref(js): Mention debug ids in sourcemap docs #13646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 181 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
App Routes Affected:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
lforst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reordering 👍 the note idk.. It especially doesn't solve the feeback in the linked lnear issue.
| <PlatformSection notSupported={["javascript.capacitor", "javascript.cordova"]}> | ||
| <Alert> | ||
|
|
||
| By default, Sentry will link source maps by injecting <PlatformLink to="/sourcemaps/troubleshooting_js/debug-ids/">Debug IDs</PlatformLink> into your build output. Alternatively, there are also <PlatformLink to="/sourcemaps/troubleshooting_js/legacy-uploading-methods/">other methods</PlatformLink> to associate source maps with Sentry that do not require modifying your build output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk about "by default" here...
| If you want to configure source maps to upload manually, follow the guide for your bundler or build tool below. | ||
|
|
||
| <PlatformSection notSupported={["javascript.capacitor", "javascript.cordova"]}> | ||
| <Alert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I like this note. Feels out of place honestly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I am very open to rephrase this, but IMHO it does make sense to mention here what all the things we are talking about on this page and subpages actually does (=inject debug ids into your build files)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you're right probably
|
@mydea - still want to make this update? |
|
ah, yes I think so, let me resolve conflicts etc (not sure if I get to it today, but I want to eventually!) |
This PR:
Closes https://linear.app/getsentry/issue/FE-398/user-feedback-debug-ids-tooling