feat(CODEOWNERS): Workaround for PR reviewers #13662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
This reverts commit b246928.
geoffg-sentry
approved these changes
May 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we made this change #8868 so that we can have codeowner review requirement enforced, but still have a reference on who owns what.
This prevented the codeowners from becoming a blocker especially when we have teams working across time zones.
But it became a bit inconvenient as the owners of files don't get tagged in PR automatically and informed for review.
This PR is meant to fix that.
The new workflow file will be triggered on all PRs, identify all the modified files in the PR, and cross match with all the commented lines in CODEOWNERS files, if there's any match it will add the owners as reviewer automatically.
Note: Approvals from reviewers added by this PR will not be required before PR can be merged, this is more of an informational and making sure proper teams are involved and informed on changes.