feat(go): add logs page #13684
Merged
feat(go): add logs page #13684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 147 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
AbhiPrasad
reviewed
May 13, 2025
Comment on lines
47
to
49
| The `Sentry.Logger` API exposes methods that support six different log levels: `trace`, | ||
| `debug`, `info`, `warn`, `error` and `fatal`. The methods support both `fmt.Print` and `fmt.Println` like syntax. Using | ||
| these methods is as simple as: |
Member
There was a problem hiding this comment.
Suggested change
| The `Sentry.Logger` API exposes methods that support six different log levels: `trace`, | |
| `debug`, `info`, `warn`, `error` and `fatal`. The methods support both `fmt.Print` and `fmt.Println` like syntax. Using | |
| these methods is as simple as: | |
| The `Sentry.Logger` API exposes methods that support six different log levels: `trace`, | |
| `debug`, `info`, `warn`, `error` and `fatal`. The methods support both `fmt.Print` and `fmt.Printf` like syntax. | |
| If you pass in format specifiers like `%v`, these will be sent to Sentry, and can be searched from within the Logs UI, and even added to the Logs views as a dedicated column. |
Comment on lines
60
to
61
| Additionally, you can attach properties to each log entry using the `attribute` API. These properties will be sent | ||
| to Sentry, and can be searched from within the Logs UI, and even added to the Logs views as a dedicated column. |
Member
There was a problem hiding this comment.
Suggested change
| Additionally, you can attach properties to each log entry using the `attribute` API. These properties will be sent | |
| to Sentry, and can be searched from within the Logs UI, and even added to the Logs views as a dedicated column. | |
| You can also pass additional attributes to the logger via the `SetAttributes` function. These attributes will also be searchable in the Logs UI. |
Comment on lines
111
to
113
| However in order to properly attach the correct Spans with each Log entry, a `context.Context` is required. The `Write` function of | ||
| the `io.Writer` interface does not provide `context` so currently wrapping the custom logger will provide limited functionality. | ||
| The recommended way is to use the `sentry.Logger` itself. |
Member
There was a problem hiding this comment.
Suggested change
| However in order to properly attach the correct Spans with each Log entry, a `context.Context` is required. The `Write` function of | |
| the `io.Writer` interface does not provide `context` so currently wrapping the custom logger will provide limited functionality. | |
| The recommended way is to use the `sentry.Logger` itself. | |
| In order to properly attach the correct trace with each Log entry, a `context.Context` is required. The `Write` function of | |
| the `io.Writer` interface does not provide `context` so wrapping the custom logger will not get the trace and current span attached. | |
| We recommend using the `sentry.Logger` to ensure your logs are connected to spans and errors in the Sentry UI. |
|
|
||
| ### Debug | ||
|
|
||
| If debug is set to true, calls to the logger will also print to the console with the appropriate log level. |
Member
There was a problem hiding this comment.
Suggested change
| If debug is set to true, calls to the logger will also print to the console with the appropriate log level. | |
| If the `Debug` init option is set to true, calls to the `sentry.Logger` APIs will also print to the console with the appropriate log level. |
coolguyzone
reviewed
May 13, 2025
| @@ -0,0 +1,143 @@ | |||
| --- | |||
| title: Set Up Logs | |||
Contributor
There was a problem hiding this comment.
Suggested change
| title: Set Up Logs | |
| title: Set Up Logs in Go |
coolguyzone
reviewed
May 13, 2025
| --- | ||
| title: Set Up Logs | ||
| sidebar_title: Logs | ||
| description: "Structured logs allow you to send, view and query logs sent from your applications within Sentry." |
Contributor
There was a problem hiding this comment.
Suggested change
| description: "Structured logs allow you to send, view and query logs sent from your applications within Sentry." | |
| description: "Structured logs allow you to send, view, and query logs sent from your applications within Sentry." |
coolguyzone
reviewed
May 13, 2025
| logger.Warnf(ctx, "I have params: %v and attributes", "example param") | ||
| } | ||
| ``` | ||
| Currently the `attribute` API supports only these value types: `int`, `string`, `bool` and `float`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Currently the `attribute` API supports only these value types: `int`, `string`, `bool` and `float`. | |
| Currently the `attribute` API supports only these value types: `int`, `string`, `bool`, and `float`. |
coolguyzone
reviewed
May 13, 2025
|
|
||
| <Alert> | ||
| In order to properly attach the correct trace with each Log entry, a `context.Context` is required. The `Write` function of | ||
| the `io.Writer` interface does not provide `context` so wrapping the custom logger will not get the trace and current span attached. |
Contributor
There was a problem hiding this comment.
Suggested change
| the `io.Writer` interface does not provide `context` so wrapping the custom logger will not get the trace and current span attached. | |
| the `io.Writer` interface doesn't provide `context`, so wrapping the custom logger will not get the trace and current span attached. |
coolguyzone
approved these changes
May 13, 2025
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Looks good! Thanks for adding 🕺
AbhiPrasad
previously requested changes
May 14, 2025
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
We'll need to update https://github.com/getsentry/sentry-docs/blob/master/docs/product/explore/logs/getting-started/index.mdx as well here!
cleptric
approved these changes
May 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
adding initial logs page for the Go SDK.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.