Skip to content

Conversation

@solnic
Copy link
Collaborator

@solnic solnic commented May 14, 2025

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:42am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 15, 2025 9:42am
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2025 9:42am

@solnic solnic force-pushed the ruby-add-logs branch 2 times, most recently from f98dbed to 0e5c899 Compare May 14, 2025 08:34
@solnic solnic marked this pull request as ready for review May 14, 2025 09:39
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merged in #13676 - we can change from alpha -> beta now.

@solnic
Copy link
Collaborator Author

solnic commented May 15, 2025

solnic and others added 3 commits May 15, 2025 11:20
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Add ruby as supported SDK
@codecov
Copy link

codecov bot commented May 15, 2025

Bundle Report

Changes will increase total bundle size by 5.07kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.19MB 5.07kB (0.05%) ⬆️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js 433 bytes 584.5kB 0.07%
../app/[[...path]]/page.js.nft.json 1.55kB 396.29kB 0.39%
../app/platform-redirect/page.js.nft.json 1.55kB 396.21kB 0.39%
../app/sitemap.xml/route.js.nft.json 1.55kB 394.18kB 0.39%

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 433 bytes 3.13MB 0.01%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/MRBKNmwmVSXvBwMvYcGF_/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/MRBKNmwmVSXvBwMvYcGF_/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/9vzBIHQBf2nJWUbO4F3DC/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/9vzBIHQBf2nJWUbO4F3DC/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@sl0thentr0py sl0thentr0py merged commit d4a62bb into master May 15, 2025
13 checks passed
@sl0thentr0py sl0thentr0py deleted the ruby-add-logs branch May 15, 2025 10:34
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants