Skip to content

Conversation

@coolguyzone
Copy link
Contributor

@coolguyzone coolguyzone commented Jul 9, 2025

DESCRIBE YOUR PR

Replacing out of date images, verify preview on: https://sentry-docs-git-ui-issues.sentry.dev/product/issues/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2025 5:59pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Jul 10, 2025 5:59pm

@codecov
Copy link

codecov bot commented Jul 9, 2025

Bundle Report

Changes will decrease total bundle size by 894.06kB (-4.05%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.81MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 11.01MB -894.05kB (-7.51%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.67MB -0.0%
../instrumentation.js -3 bytes 997.28kB -0.0%
9523.js -3 bytes 973.22kB -0.0%
../app/[[...path]]/page.js.nft.json -298.01kB 404.23kB -42.44%
../app/platform-redirect/page.js.nft.json -298.01kB 404.14kB -42.44%
../app/sitemap.xml/route.js.nft.json -298.01kB 402.12kB -42.57%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 878.27kB -0.0%
static/chunks/1831-*.js -3 bytes 421.22kB -0.0%
static/kiTHOmV_Ttp1VQZNMP4IT/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/kiTHOmV_Ttp1VQZNMP4IT/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Q7KG9rHcCPVOc3XRzV4Lv/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/Q7KG9rHcCPVOc3XRzV4Lv/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@sfanahata
Copy link
Contributor

@coolguyzone I'm not seeing the new images on the preview.
image

@coolguyzone
Copy link
Contributor Author

@sfanahata Weird, I'm almost certain they were showing up yesterday. I went ahead and re-deployed preview and they are showing up correctly again (at least on my end 🙃)

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now!
image

Nit, and not officially part of the image changes, but in the doc we say "Change how issues are sorted in the issues stream by selecting from the sort dropdown:", but the dropdown is not labeled "sort". It's labeled "last seen". It'd be nice to change that line to "...selecting from the last seen dropdown", but not a blocker.

@coolguyzone coolguyzone merged commit ef1cbd6 into master Jul 10, 2025
13 checks passed
@coolguyzone coolguyzone deleted the ui-issues branch July 10, 2025 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants