-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Replace imgs to match new ui #14309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace imgs to match new ui #14309
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 894.06kB (-4.05%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
|
@coolguyzone I'm not seeing the new images on the preview. |
|
@sfanahata Weird, I'm almost certain they were showing up yesterday. I went ahead and re-deployed preview and they are showing up correctly again (at least on my end 🙃) |
sfanahata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, and not officially part of the image changes, but in the doc we say "Change how issues are sorted in the issues stream by selecting from the sort dropdown:", but the dropdown is not labeled "sort". It's labeled "last seen". It'd be nice to change that line to "...selecting from the last seen dropdown", but not a blocker.


DESCRIBE YOUR PR
Replacing out of date images, verify preview on: https://sentry-docs-git-ui-issues.sentry.dev/product/issues/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES