-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(hydration errors): Add a FAQ entry about strange html diffs #14672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 3.52kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
docs/product/issues/issue-details/replay-issues/hydration-error.mdx
Outdated
Show resolved
Hide resolved
|
|
||
|  | ||
|
|
||
| The class name `:hover` was added Session Replay when it serialized the page, React didn't see this class and it has no impact on hydration. This means the user was hovering and interacting with the page before react was finished hydrating (this is the whole point of hydration; to make the page react for interaction sooner!). By the time hydration was complete the user had moved their mouse so the :hover class is changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The class name `:hover` was added Session Replay when it serialized the page, React didn't see this class and it has no impact on hydration. This means the user was hovering and interacting with the page before react was finished hydrating (this is the whole point of hydration; to make the page react for interaction sooner!). By the time hydration was complete the user had moved their mouse so the :hover class is changed. | |
| The class name `:hover` was added by the Replay SDK when it serialized the page. React didn't see this class and it has no impact on hydration. This means the user was hovering and interacting with the page before React was finished hydrating (this is the whole point of hydration; to make the page react for interaction sooner!). By the time hydration was complete, the user had moved their mouse, so the `:hover` class is changed. |
to? by?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think by, in the sentence it's doing the thing.
added to the serialized json.. like 'added to the [serialzied] replay [data]'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could do 'by the replay sdk`
Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>
The original ticket was something like "Sentry raises attribute order or empty spaces in values as Hydration errors that have no effect on the HTML rendering"
I wrote a response on the ticket, but since this is a common enough thing I think it should be in the FAQ too. It's a good question that we've gotten before.
Fixes getsentry/sentry#97828