Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Aug 21, 2025

DESCRIBE YOUR PR

Add docs for experimental structured logs for Apple platforms.

Closes getsentry/sentry-cocoa#5986

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: Logs GA
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Aug 21, 2025

@denrase is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@denrase denrase marked this pull request as ready for review August 21, 2025 09:43
@denrase denrase requested a review from philipphofmann August 21, 2025 11:19
@kahest kahest requested review from itaybre and philprime August 21, 2025 11:22
@vercel
Copy link

vercel bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Aug 26, 2025 0:24am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Aug 26, 2025 0:24am

Copy link
Contributor

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first quick pass, lgtm. gonna let at least one of the Cocoa engs take a look as well

Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
@kahest kahest requested a review from AbhiPrasad August 21, 2025 11:35
@denrase denrase requested a review from kahest August 25, 2025 08:18
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment to confirm

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denrase denrase merged commit e64ff21 into getsentry:master Aug 26, 2025
12 of 15 checks passed
@denrase denrase deleted the denrase/cocoa-structured-logs branch August 26, 2025 13:01
AbhiPrasad added a commit that referenced this pull request Aug 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structured Logs: Docs

4 participants