-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(releases): De-duplicate release naming docs, and centralize in /product/releases/naming-releases/ #14748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…product/releases/naming-releases/
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 17.05kB (0.07%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
| The value can be arbitrary, but for certain platforms, recommendations exist: | ||
|
|
||
| - for mobile devices use `package-name@version-number` or `package-name@version-number+build-number`. **Do not** use `VERSION_NUMBER (BUILD_NUMBER)` as the parenthesis are used for display purposes (foo@1.0+2 becomes 1.0 (2)), so invoking them will cause an error. | ||
| - if you use a DVCS we recommend using the identifying hash (eg: the commit SHA, `da39a3ee5e6b4b0d3255bfef95601890afd80709`). You can let sentry-cli automatically determine this hash for supported version control systems with `sentry-cli releases propose-version`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part is not included in the new snippet. is it important to include there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was thinking that it's ok to bury it under "There are some release name restrictions and conventions to be aware of. Learn more about Naming Releases." but i can add it back if that link's easy to miss and the content is more useful to be here up-front.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay to shorten this section, but I would suggest adding a little bit more info in the linked area. I'll add a comment with a suggestion there.
|
|
||
| - for mobile devices use `package-name@version-number` or `package-name@version-number+build-number`. **Do not** use `VERSION_NUMBER (BUILD_NUMBER)` as the parenthesis are used for display purposes (foo@1.0+2 becomes 1.0 (2)), so invoking them will cause an error. | ||
| - if you use a DVCS we recommend using the identifying hash (eg: the commit SHA, `da39a3ee5e6b4b0d3255bfef95601890afd80709`). You can let sentry-cli automatically determine this hash for supported version control systems with `sentry-cli releases propose-version`. | ||
| - if you tag releases we recommend using the release tag prefixed with a product or package name (for example, `my-project-name@2.3.12`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with this
Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>
Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>
jas-kas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up! A lot less repeated content now 😅
Since we're auditing all these release doc files, the platform docs all being named "Releases & Health" is odd. Shouldn't it be "Release Health"? Or if anything, I'd make it "Releases".
Since this is under the "Configuration" nav item, "Releases" make sense as that is the entity you're configuring. Maybe you can add this bulk change to the PR 👼
includes/bind-release-version.mdx
Outdated
|
|
||
| There are some release name restrictions and conventions to be aware of. [Learn more about Naming Releases](/product/releases/naming-releases/). | ||
|
|
||
| Releases can also be auto-created by different systems -- for instance, upon uploading a source map, or by some clients when an event that is tagged with a release is ingested. Therefore, it's important to set the release name when building and deploying your application. Learn more in our [Releases](/platform-redirect/?next=/configuration/releases/) documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This releases link just brings users back to the same exact page they are already on, with the added step of having to select a platform. 🤔 What information do you want to point to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these links go out to different pages
the platform specific page talks about sessions and has platform specific snippets.
includes/bind-release-version.mdx
Outdated
|
|
||
| There are some release name restrictions and conventions to be aware of. [Learn more about Naming Releases](/product/releases/naming-releases/). | ||
|
|
||
| Releases can also be auto-created by different systems -- for instance, upon uploading a source map, or by some clients when an event that is tagged with a release is ingested. Therefore, it's important to set the release name when building and deploying your application. Learn more in our [Releases](/platform-redirect/?next=/configuration/releases/) documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Releases can also be auto-created by different systems -- for instance, upon uploading a source map, or by some clients when an event that is tagged with a release is ingested. Therefore, it's important to set the release name when building and deploying your application. Learn more in our [Releases](/platform-redirect/?next=/configuration/releases/) documentation. | |
| Releases can also be auto-created by different systems—for instance, upon uploading a source map, or by some clients when an event that is tagged with a release is ingested. Therefore, it's important to set the release name when building and deploying your application. Learn more in our [Releases](/platform-redirect/?next=/configuration/releases/) documentation. |
sfanahata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this change! Thanks for giving the docs some includes goodness. I noted that I think it's still valuable to add the top level info about naming restrictions to the includes file, but otherwise, just added a couple of nits. Looks great. <3
Co-authored-by: Jasmin <77064737+jas-kas@users.noreply.github.com> Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
I noticed we had a lot of duplicate pages with the same docs related to release names.
The goal of this PR is to:
The new central page is available at:
/product/releases/naming-releases/Some existing pages are now more streamlined and will link to the new central location:
/cli/releases//platforms/javascript/configuration/releases/(19 platform pages with the exact same content)