Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 29, 2025

DESCRIBE YOUR PR

This PR makes a change to the order in which we show the version select items if a docs page has multiple versions: Instead of sorting the version designator alphabetically, this PR attempts to sort them by recent to oldest. For now, this only looks at the major number, since the version designator can be arbitrary and we can't assume proper semver (see example).If we can't extract a proper major version, we continue to sort alphabetically.

Before:
image

After:
image

(the 10x version in this screenshot serves an illustrative purpose. I'm not shipping that anytime soon :D)

(This PR is brought to you by a sidequest while working on updating sveltekit docs and encountering weird ordering. Happy to close/adjust as reviewers see fit :) )

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: Some time week ending Sept 5th
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Aug 29, 2025 10:21am
sentry-docs Ready Ready Preview Comment Aug 29, 2025 10:21am

cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Aug 29, 2025

Bundle Report

Changes will increase total bundle size by 3.04kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.9MB 159 bytes (0.0%) ⬆️
sentry-docs-server-cjs 12.52MB 2.88kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/chunks/4145-*.js 165 bytes 49.97kB 0.33%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/y-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/y-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/mDqfoH1P9LSWl91AQtRJk/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/mDqfoH1P9LSWl91AQtRJk/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 909 bytes 776.93kB 0.12%
../app/platform-redirect/page.js.nft.json 909 bytes 776.85kB 0.12%
../app/sitemap.xml/route.js.nft.json 909 bytes 774.32kB 0.12%
4873.js 165 bytes 89.69kB 0.18%

Files in 4873.js:

  • ./src/components/versionSelector/index.tsx → Total Size: 485 bytes

cursor[bot]

This comment was marked as outdated.

@Lms24 Lms24 requested a review from sergical August 29, 2025 09:49
@Lms24 Lms24 enabled auto-merge (squash) August 29, 2025 10:08
@Lms24 Lms24 merged commit 4a63983 into master Aug 29, 2025
15 checks passed
@Lms24 Lms24 deleted the lms/fix-platform-versioned-docs-order branch August 29, 2025 10:21
codyde added a commit that referenced this pull request Aug 30, 2025
* 'master' of https://github.com/getsentry/sentry-docs:
  Layout updates; widening content div, centering and responsiveness, scrollbar update (#14766)
  Document default sdk logging attributes (#14353)
  Bump API schema to b8165143 (#14764)
  fix(OnboardingOptionButtons) Remove sticky css on mobile (#14690)
  Unreal Engine: Add migration guide (#14186)
  docs(ai): Update AI agent integrations list (#14769)
  fix: Order versioned docs select items by recency (#14768)
  ref(python): Update wording regarding async init (#14631)
  docs(aws-integration): Remove alert that ESM is not supported (#14756)
  fix(feedback): Update docs with SwiftUI notes (#14227)
  chore(docs): Remove explicit openai agents integration registration (#14718)
  Update list of states subject to tax on /pricing (#14763)
  ref(replay): Refactor pages inside the Product Walkthrough > Replay area (#14712)
  docs(replay): Move FAQ Replay for Android questions into dedicated troubleshooting page (#14709)
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants