-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Update CDN bundle & loader docs #14774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the JavaScript SDK loader and CDN documentation to reflect current UI navigation paths and available bundle options. The changes address outdated instructions and bundle configurations to align with the current state of the Sentry platform.
- Updated navigation instructions for accessing loader settings in the Sentry UI
- Corrected bundle availability information, removing references to deprecated ES5 bundles
- Added documentation for new bundle types including feedback and full feature bundles
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| integrity="sha384-{{@inject packages.checksum('sentry.javascript.browser', 'bundle.tracing.replay.min.js', 'sha384-base64') }}" | ||
| crossorigin="anonymous" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bug: The 'Full Bundle' script tag has a mismatched integrity hash in loader.mdx, causing SRI failures that will prevent the Sentry SDK from loading for users.
-
Description: The script tag for the 'Full Bundle' in
loader.mdxspecifiesbundle.tracing.replay.feedback.min.jsas the source. However, theintegrityattribute is generated using the checksum forbundle.tracing.replay.min.jsvia the@inject packages.checksumhelper. This mismatch will cause browsers to fail the Subresource Integrity (SRI) check and refuse to execute the script. As a consequence, users copying this snippet will have the Sentry SDK fail to initialize silently, resulting in a complete loss of error monitoring, tracing, and replay functionality. -
Suggested fix: Update the
@inject packages.checksumcall within theintegrityattribute to use the correct filename,bundle.tracing.replay.feedback.min.js, ensuring it matches thesrcattribute of the script tag.
severity: 0.658, confidence: 1.0
Did we get this right? 👍 / 👎 to inform future reviews.
Bundle ReportChanges will increase total bundle size by 657 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
I noticed we had a few incorrect things in our loader/cdn docs: