Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Sep 1, 2025

I noticed we had a few incorrect things in our loader/cdn docs:

  1. Instructions to get to loader settings where not correct anymore
  2. Instructions about es5 bundles where incorrect (they no longer exist)
  3. We missed a few bundles/I updated some things to be more up-to-date, including feedback as well.

@mydea mydea requested review from Lms24, chargome and Copilot September 1, 2025 08:43
@mydea mydea self-assigned this Sep 1, 2025
@mydea mydea requested a review from andreiborza September 1, 2025 08:43
@vercel
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Sep 1, 2025 10:08am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Sep 1, 2025 10:08am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the JavaScript SDK loader and CDN documentation to reflect current UI navigation paths and available bundle options. The changes address outdated instructions and bundle configurations to align with the current state of the Sentry platform.

  • Updated navigation instructions for accessing loader settings in the Sentry UI
  • Corrected bundle availability information, removing references to deprecated ES5 bundles
  • Added documentation for new bundle types including feedback and full feature bundles

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cursor[bot]

This comment was marked as outdated.

Comment on lines 249 to 250
integrity="sha384-{{@inject packages.checksum('sentry.javascript.browser', 'bundle.tracing.replay.min.js', 'sha384-base64') }}"
crossorigin="anonymous"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The 'Full Bundle' script tag has a mismatched integrity hash in loader.mdx, causing SRI failures that will prevent the Sentry SDK from loading for users.
  • Description: The script tag for the 'Full Bundle' in loader.mdx specifies bundle.tracing.replay.feedback.min.js as the source. However, the integrity attribute is generated using the checksum for bundle.tracing.replay.min.js via the @inject packages.checksum helper. This mismatch will cause browsers to fail the Subresource Integrity (SRI) check and refuse to execute the script. As a consequence, users copying this snippet will have the Sentry SDK fail to initialize silently, resulting in a complete loss of error monitoring, tracing, and replay functionality.

  • Suggested fix: Update the @inject packages.checksum call within the integrity attribute to use the correct filename, bundle.tracing.replay.feedback.min.js, ensuring it matches the src attribute of the script tag.
    severity: 0.658, confidence: 1.0

Did we get this right? 👍 / 👎 to inform future reviews.

@codecov
Copy link

codecov bot commented Sep 1, 2025

Bundle Report

Changes will increase total bundle size by 657 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.9MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.54MB 663 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 224 bytes 783.92kB 0.03%
../app/platform-redirect/page.js.nft.json 224 bytes 783.83kB 0.03%
../app/sitemap.xml/route.js.nft.json 224 bytes 781.3kB 0.03%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/D3orFY2V0pD3PzvmZJb4j/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/D3orFY2V0pD3PzvmZJb4j/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/aV2ThlIUlTtsSUjs7RvPy/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/aV2ThlIUlTtsSUjs7RvPy/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

mydea and others added 2 commits September 1, 2025 11:28
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
@mydea mydea merged commit 867c9a1 into master Sep 1, 2025
13 checks passed
@mydea mydea deleted the fn/loader-docs branch September 1, 2025 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants