Skip to content

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Sep 2, 2025

DESCRIBE YOUR PR

This change adds an interactive snippet on how to start Sentry React Native with Log support.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Sep 2, 2025 4:09pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Sep 2, 2025 4:09pm

@codeowner-assignment codeowner-assignment bot requested a review from a team September 2, 2025 15:34
Comment on lines +87 to +88
enableLogs: true,
// ___PRODUCT_OPTION_END___ logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The React Native getting started guide uses an incorrect configuration, enableLogs: true. The SDK requires _experiments: { enableLogs: true }, causing logs to be silently dropped.
  • Description: The React Native getting started guide was updated to use enableLogs: true in the Sentry.init() call. However, the React Native SDK requires this option to be nested under an _experiments key, as in _experiments: { enableLogs: true }. The top-level enableLogs property is part of the JavaScript SDK v10, but this change was not adopted by the React Native SDK. Consequently, users following the updated guide will have logging silently disabled, as the configuration will be ignored without raising an error.

  • Suggested fix: Update the Sentry.init() example in the React Native getting started guide. Replace the top-level enableLogs: true property with _experiments: { enableLogs: true } to match the correct API for the React Native SDK.
    severity: 0.72, confidence: 0.98

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a bad suggestion, it just isn't aware of an open PR changing this according to the updated implementation that will be merged at the same time as this

@codecov
Copy link

codecov bot commented Sep 2, 2025

Bundle Report

Changes will increase total bundle size by 960 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.9MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.55MB 966 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 325 bytes 785.44kB 0.04%
../app/platform-redirect/page.js.nft.json 325 bytes 785.35kB 0.04%
../app/sitemap.xml/route.js.nft.json 325 bytes 782.82kB 0.04%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/K9shJMLs8cCKT2ilkQF-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/K9shJMLs8cCKT2ilkQF-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/HIT6xRIuebijI0m5xD4el/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/HIT6xRIuebijI0m5xD4el/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
thank you for updating this 🙇

@kahest kahest merged commit b33022a into master Sep 2, 2025
13 checks passed
@kahest kahest deleted the lz/rn-log/getting-started branch September 2, 2025 17:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants