-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add mobile performance score section #14923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mobile performance score section #14923
Conversation
Co-authored-by: sergiy.dybskiy <sergiy.dybskiy@sentry.io>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 493 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
sfanahata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergical - looks good. Are those numbers represented within our product?
Yeah, the logic is here: https://github.com/getsentry/sentry/blob/master/static/app/views/insights/mobile/screens/utils.ts#L84-L138 we just didn't have anything similar to https://docs.sentry.io/product/insights/frontend/web-vitals/#performance-score for mobile |
DESCRIBE YOUR PR
Adds a "Performance Score" section to the Mobile Vitals documentation (
/product/insights/mobile/mobile-vitals/) with a table detailing the thresholds for "Good", "Meh", and "Poor" average cold and warm app start times. This change addresses a user request to clarify how these mobile vital metrics are scored within Sentry, similar to the existing Web Vitals performance score documentation.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
Slack Thread