Document catchall variant for protocol enums #14947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
tobias-wilfert
approved these changes
Sep 17, 2025
Dav1dde
approved these changes
Sep 17, 2025
Comment on lines
+27
to
+28
| /// Unknown color, for forward compatibility. | ||
| Unknown(String), |
Member
There was a problem hiding this comment.
Sometimes we use #[serde(other)] Unknown, sometimes Unknown(String) and other times our derives have something builtin #[metastructure(fallback_variant)].
Seems to be quite use-case specific and hard to phrase :/.
Member
Author
There was a problem hiding this comment.
Yes I looked at fallback_variant and it seems we only use it with Object. I guess the important part is that we have some sort of fallback such that parsing does not fail and the data is forwarded.
coolguyzone
approved these changes
Sep 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for example getsentry/relay#5144.