Skip to content

Conversation

@Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Sep 17, 2025

DESCRIBE YOUR PR

  • The permission change no longer works, due to Relay having a different base docker container. I opted to use busybox to make the permission change (with the new user/group id) to make it fully copy pastable, the alternative would be a sudo chown from the host.
  • Fixed the $(pwd) quoting, this would fail on paths with spaces.
  • Switched the registry to ghcr.io as the dockerhub image is seemingly deprecated
image

Fixes: INGEST-579

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Sep 17, 2025 9:05am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Sep 17, 2025 9:05am

@Dav1dde Dav1dde requested a review from a team September 17, 2025 07:06
@Dav1dde Dav1dde force-pushed the dav1d/relay-docker-docs branch from ea58041 to 20e704a Compare September 17, 2025 07:07
@Dav1dde Dav1dde force-pushed the dav1d/relay-docker-docs branch from 20e704a to 1e1fd7a Compare September 17, 2025 07:08
@linear
Copy link

linear bot commented Sep 17, 2025

@codecov
Copy link

codecov bot commented Sep 17, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.91MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.64MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/tfcRLuz61FFqo7b7CwTxA/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/tfcRLuz61FFqo7b7CwTxA/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/3TQ32GPtWTagXwxCclQtG/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/3TQ32GPtWTagXwxCclQtG/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@Dav1dde Dav1dde enabled auto-merge (squash) September 17, 2025 08:07
@Dav1dde Dav1dde disabled auto-merge September 17, 2025 08:15
@Dav1dde Dav1dde enabled auto-merge (squash) September 17, 2025 08:36
--entrypoint bash \
getsentry/relay \
-c 'chown -R relay:relay /work/.relay'
chown -R 65532:65532 ./config
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Docker Volume Initialization and Path Consistency Issue

The chown command runs on the host and assumes the ./config directory exists, causing a "No such file or directory" error on first run because the directory isn't created by Docker yet. Also, the path inconsistency between chown's ./config and Docker's "$(pwd)"/config/ might cause permissions to be applied to an unintended directory.

Fix in Cursor Fix in Web

@Dav1dde Dav1dde merged commit cc718df into master Sep 17, 2025
13 checks passed
@Dav1dde Dav1dde deleted the dav1d/relay-docker-docs branch September 17, 2025 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants