-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(relay): Fix Relay docker commands, registry, nonroot #14955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
ea58041 to
20e704a
Compare
20e704a to
1e1fd7a
Compare
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
| --entrypoint bash \ | ||
| getsentry/relay \ | ||
| -c 'chown -R relay:relay /work/.relay' | ||
| chown -R 65532:65532 ./config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Docker Volume Initialization and Path Consistency Issue
The chown command runs on the host and assumes the ./config directory exists, causing a "No such file or directory" error on first run because the directory isn't created by Docker yet. Also, the path inconsistency between chown's ./config and Docker's "$(pwd)"/config/ might cause permissions to be applied to an unintended directory.
DESCRIBE YOUR PR
I opted to use busybox to make the permission change (with the new user/group id) to make it fully copy pastable, the alternative would be asudo chownfrom the host.$(pwd)quoting, this would fail on paths with spaces.Fixes: INGEST-579
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: