Skip to content

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Sep 26, 2025

DESCRIBE YOUR PR

Make sure all *_sampler options and all profiler related options are documented.

Preview:
https://sentry-docs-git-antonpirker-pythonoptions-samplers.sentry.dev/platforms/python/configuration/options/

refs #12606

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES


Note

Documents new profiling sampling options and refines sampler option descriptions for errors and tracing in Python SDK docs.

  • Python SDK Docs:
    • Profiling:
      • Add profiler_mode option (scheduler selection: "thread", "gevent", "unknown", or deprecated "sleep").
      • Add profiles_sample_rate and profiles_sampler with required either/or enablement and note that tracing must be enabled.
    • Samplers:
      • Refine error_sampler description to clearly state function parameters (event, hint) and return types (boolean or 0–1 probability).
      • Clarify traces_sampler signature to accept sampling_context and move enablement note (either this or traces_sample_rate).

Written by Cursor Bugbot for commit 5d30d6d. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Sep 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Sep 29, 2025 9:41am
sentry-docs Canceled Canceled Sep 29, 2025 9:41am

@antonpirker antonpirker marked this pull request as ready for review September 26, 2025 11:41
@antonpirker antonpirker enabled auto-merge (squash) September 26, 2025 11:41
@codecov
Copy link

codecov bot commented Sep 26, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.13MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.9MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -6.46kB 1.0kB -86.59%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
static/z1MRc-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/z1MRc-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Rlngtb9h_BMpz-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/Rlngtb9h_BMpz-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! Looks good overall, but please check comments before merging.

@antonpirker antonpirker merged commit 6a0c037 into master Sep 29, 2025
13 checks passed
@antonpirker antonpirker deleted the antonpirker/python/options-samplers branch September 29, 2025 09:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants