-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Web vitals refresh #15100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web vitals refresh #15100
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 37.58kB (0.16%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
|
@sentry can you review this |
| The interactive demo below walks through how to get insights on your Web Vitals. | ||
|
|
||
| <Arcade src="https://demo.arcade.software/pSDa9dkXo1yB4HIuGVuz?embed" /> | ||
| <Arcade src="https://demo.arcade.software/N9e0ghMonxkDJR2o03kG?embed" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the arcade overall. I feel like I got a little lost going to the specific /products page. I think it's because the page we are on when that happens is maybe too zoomed in, or you just jump ahead.
A lot of it feels maybe slightly too zoomed in.
Last thing - the trace portion at the end. If we're going to show going there and further debugging, it'd be great to add a popup that says "found the issue", or describes what you're doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking, but I do think the arcade could be clearer. I also had a hard time following the wall of text as it was describing where on the page to look, particularly for the "vital values" and "scores". That one is a little hard to describe visually and functionally without me feeling a bit lost. An image of the top of the page, or of those 4 cards below the score could be nice.
|
@sentry review |
|
@sfanahata thanks for the feedback, since the arcade can be updated outside of the repo I'm gonna go ahead and merge. |
DESCRIBE YOUR PR
Copy refresh and update old Arcade.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES