Skip to content

Conversation

@coolguyzone
Copy link
Contributor

@coolguyzone coolguyzone commented Oct 1, 2025

DESCRIBE YOUR PR

Copy refresh and update old Arcade.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 7, 2025 7:11pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 7, 2025 7:11pm

@codeowner-assignment codeowner-assignment bot requested a review from a team October 1, 2025 17:08
@codecov
Copy link

codecov bot commented Oct 1, 2025

Bundle Report

Changes will increase total bundle size by 37.58kB (0.16%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.13MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.94MB 37.59kB (0.29%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 12.53kB 851.69kB 1.49%
../app/platform-redirect/page.js.nft.json 12.53kB 851.61kB 1.49%
../app/sitemap.xml/route.js.nft.json 12.53kB 848.84kB 1.5%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/J8-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/J8-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/RH6soRjtNTMCKdulK9H5W/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/RH6soRjtNTMCKdulK9H5W/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@codyde
Copy link
Contributor

codyde commented Oct 1, 2025

@sentry can you review this

The interactive demo below walks through how to get insights on your Web Vitals.

<Arcade src="https://demo.arcade.software/pSDa9dkXo1yB4HIuGVuz?embed" />
<Arcade src="https://demo.arcade.software/N9e0ghMonxkDJR2o03kG?embed" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the arcade overall. I feel like I got a little lost going to the specific /products page. I think it's because the page we are on when that happens is maybe too zoomed in, or you just jump ahead.

A lot of it feels maybe slightly too zoomed in.

Last thing - the trace portion at the end. If we're going to show going there and further debugging, it'd be great to add a popup that says "found the issue", or describes what you're doing.

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, but I do think the arcade could be clearer. I also had a hard time following the wall of text as it was describing where on the page to look, particularly for the "vital values" and "scores". That one is a little hard to describe visually and functionally without me feeling a bit lost. An image of the top of the page, or of those 4 cards below the score could be nice.

@sfanahata
Copy link
Contributor

@sentry can you review this

@codyde - did you mean to call Sentry to do a code review? It's @sentry review if so.

@sfanahata
Copy link
Contributor

@sentry review

@coolguyzone
Copy link
Contributor Author

@sfanahata thanks for the feedback, since the arcade can be updated outside of the repo I'm gonna go ahead and merge.

@coolguyzone coolguyzone merged commit ed47cde into master Oct 7, 2025
13 checks passed
@coolguyzone coolguyzone deleted the web-vitals-refresh branch October 7, 2025 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants