fix: Clarify error level impact on sessions #15198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify in the develop docs that only events with level error or higher must mark sessions as errored.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
philipphofmann
commented
Oct 14, 2025
Co-authored-by: philipp.hofmann <philipp.hofmann@sentry.io>
philipphofmann
commented
Oct 14, 2025
Co-authored-by: philipp.hofmann <philipp.hofmann@sentry.io>
philipphofmann
commented
Oct 14, 2025
Co-authored-by: philipp.hofmann <philipp.hofmann@sentry.io>
romtsn
approved these changes
Oct 14, 2025
ryan953
reviewed
Oct 14, 2025
ryan953
reviewed
Oct 14, 2025
There was a problem hiding this comment.
maybe it's just my style, but i'd love to also see like a table of all the related factors so i can see which properties affect session status, but also which properties do not.
Something like this:
| method | level | hasStacktrace | resulting session status |
|---|---|---|---|
| captureException | error |
false or true |
error |
| etc... |
|
I added a table, @ryan953, is it clearer now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Clarify in the develop docs that only events with level error or higher must mark sessions as errored.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: