ref(develop/spans): Replace is_remote with is_segment in Span Protocol
#15415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Dav1dde
approved these changes
Nov 5, 2025
| | `name` | string | Yes | A low cardinality description of what the span represents (e.g., "GET /users", "database.query") | | ||
| | `status` | string | Yes | Status of the span operation. Either `"ok"` or `"error"` | | ||
| | `is_remote` | boolean | Yes | Whether the SpanContext creating the span was received from somewhere else or locally generated | | ||
| | `is_segment` | boolean | Yes | Whether the span is a segment span | |
Member
There was a problem hiding this comment.
Technically we decided not to require it for compatibility reasons with otel, but I am good with keeping it as required here for our own SDKs 👍.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to remove the
is_remotefield on the Span v2 items in favour of the newis_segmentfield.