Skip to content

Conversation

@sergical
Copy link
Member

@sergical sergical commented Nov 20, 2025

DESCRIBE YOUR PR

  • Code blocks were overflowing which made content overflow making for a poor mobile experience
Before After
CleanShot 2025-11-20 at 10 39 38 CleanShot 2025-11-20 at 10 39 59
  • Scrollbars looked janky on mobile
Before After
CleanShot 2025-11-20 at 10 35 46 CleanShot 2025-11-20 at 10 35 10
CleanShot 2025-11-20 at 10 35 36 CleanShot 2025-11-20 at 10 35 20

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Nov 20, 2025 3:50pm
sentry-docs Ready Ready Preview Comment Nov 20, 2025 3:50pm

@codecov
Copy link

codecov bot commented Nov 20, 2025

Bundle Report

Changes will increase total bundle size by 162.34kB (0.69%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 12.97MB 160.39kB (1.25%) ⬆️
sentry-docs-client-array-push 10.17MB 1.95kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/css/*.css 1.28kB 23.98kB 5.63% ⚠️
static/css/*.css 27 bytes 748.34kB 0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/chunks/app/[[...path]]/page-*.js 653 bytes 96.76kB 0.68%
static/Sl-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Sl-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/rdDZpnbbvn6cFzi7hSlc4/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/rdDZpnbbvn6cFzi7hSlc4/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/app/[[...path]]/page-*.js:

  • ./src/components/codeTabs.tsx → Total Size: 7.32kB

  • ./src/components/codeBlock/code-blocks.module.scss → Total Size: 309 bytes

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 53.17kB 885.66kB 6.39% ⚠️
../app/platform-redirect/page.js.nft.json 53.17kB 885.58kB 6.39% ⚠️
../app/sitemap.xml/route.js.nft.json 53.17kB 882.81kB 6.41% ⚠️
../app/[[...path]]/page.js 562 bytes 620.66kB 0.09%
4236.js 332 bytes 100.57kB 0.33%

Files in ../app/[[...path]]/page.js:

  • ./src/components/codeTabs.tsx → Total Size: 6.28kB

  • ./src/components/codeBlock/code-blocks.module.scss → Total Size: 300 bytes

  • ./src/components/codeTabs.tsx → Total Size: 444 bytes

Files in 4236.js:

  • ./src/components/docPage/type.scss → Total Size: 1 bytes

  • ./src/components/docPage/index.tsx → Total Size: 11.69kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 562 bytes 3.37MB 0.02%

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS/SASS looks good, spot checked several SDKs/pages on mobiles and the changes look good.

@sergical sergical merged commit a3ac971 into master Nov 20, 2025
16 checks passed
@sergical sergical deleted the sergical/mobile-fixes branch November 20, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants