Skip to content

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Nov 24, 2025

DESCRIBE YOUR PR

image

The grouping makes no sense at the moment, My fix is to replace the "dsn" group by "core options"

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Nov 28, 2025 1:17pm
sentry-docs Ready Ready Preview Comment Nov 28, 2025 1:17pm

@codeowner-assignment codeowner-assignment bot requested a review from a team November 24, 2025 20:36
@lucas-zimerman lucas-zimerman changed the title ref(react-native): remover dsn as main group. ref(react-native): remove dsn as main group. Nov 24, 2025
@lucas-zimerman lucas-zimerman assigned alwx and unassigned alwx Nov 24, 2025
@lucas-zimerman lucas-zimerman requested a review from alwx November 24, 2025 21:06
@codecov
Copy link

codecov bot commented Nov 24, 2025

Bundle Report

Changes will decrease total bundle size by 290.69kB (-0.82%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 24.56MB -290.68kB (-1.17%) ⬇️
sentry-docs-client-array-push 10.22MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 5.5MB -0.0%
6529.js -3 bytes 4.92MB -0.0%
../instrumentation.js -3 bytes 4.82MB -0.0%
../app/[[...path]]/page.js.nft.json -96.89kB 983.17kB -8.97%
../app/platform-redirect/page.js.nft.json -96.89kB 983.08kB -8.97%
../app/sitemap.xml/route.js.nft.json -96.89kB 980.61kB -8.99%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 893.1kB -0.0%
static/chunks/9366-*.js -3 bytes 436.99kB -0.0%
static/dxHGKbpGGJIIcIrUKAiPl/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/dxHGKbpGGJIIcIrUKAiPl/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/D7OpGgu1-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/D7OpGgu1-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 Thank you for fixing this Lucas 🙇
LGTM! Adding a before-after screenshot for reference on what changed.

Image

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) November 28, 2025 13:06
@codeowner-assignment codeowner-assignment bot requested a review from a team November 28, 2025 13:06
@lucas-zimerman lucas-zimerman merged commit 22eb3ca into master Nov 28, 2025
13 of 14 checks passed
@lucas-zimerman lucas-zimerman deleted the lz/rn-coreoption branch November 28, 2025 13:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants