-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs: Add Fastlane Plugin documentation for Size Analysis #16144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add documentation for using sentry-fastlane-plugin to upload builds for Size Analysis on Android, iOS, and React Native platforms. - Add Fastlane Plugin as upload mechanism for Android (AAB/APK) - Add Fastlane Plugin as upload mechanism for React Native Android - Update iOS Fastlane docs with clear XCArchive vs IPA examples - Create new upload-fastlane-android.mdx include file - Add version requirement notes (2.0.0-rc.3+) for APK, AAB, IPA uploads
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions. Thanks for adding this 👍
- Change references to the Fastlane upload mechanism for iOS builds to the new `upload-fastlane-ios` include file across multiple guides. - Add a new `upload-fastlane-ios.mdx` file detailing the process for uploading XCArchive and IPA builds to Sentry. - Introduce `upload-fastlane-android` include file for Android builds, enhancing documentation for both platforms. This update improves clarity and organization of the Fastlane documentation for size analysis.
coolguyzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding 🫡
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @philprime, LGTM 😃
DESCRIBE YOUR PR
This PR adds documentation for using the sentry-fastlane-plugin to upload builds for Size Analysis on Android, iOS, and React Native platforms.
Changes:
upload-fastlane-android.mdxinclude file with Android-specific examples2.0.0-rc.3or laterFiles changed:
docs/platforms/android/size-analysis/index.mdx- Added Fastlane Plugin optiondocs/platforms/react-native/size-analysis/index.mdx- Added Fastlane Plugin option for Androidincludes/size-analysis/upload-fastlane.mdx- Updated with clear XCArchive/IPA examplesincludes/size-analysis/upload-fastlane-android.mdx- New file for Android Fastlane docsIS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
Closes getsentry/sentry-fastlane-plugin#391