docs(cloudflare,nextjs): Move NextJS on CF instructions directly to CF#16224
docs(cloudflare,nextjs): Move NextJS on CF instructions directly to CF#16224
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Not sure about this one, feels like users deploying Next.js are more likely to look for in Next.js rather than cloudflare. But I don't have a strong opinion here. |
chargome
left a comment
There was a problem hiding this comment.
I'm fine with this as we also have other frameworks there, just keep the reference in the next.js docs 👍
@JPeer264 logaf-l: this is not a feat as this pr contains no docs platform changes, so I would change to docs(cloudflare,nextjs):...
|
The reference will ofc stay: https://github.com/getsentry/sentry-docs/blob/5523afc67b00bdbb7c292ba1351e87e0c2f46b4a/docs/platforms/javascript/guides/nextjs/best-practices/deploying-on-cloudflare.mdx (this is then also better for SEO if this can be found in both locations - at least I hope so) |
5523afc to
6b94236
Compare
|
|
||
| ## Configure Wrangler | ||
|
|
||
| Once you've set up Sentry in your Next.js application following the [installation guide](/platforms/javascript/guides/nextjs/), you'll need to configure Wrangler with the required compatibility settings. |
There was a problem hiding this comment.
| Once you've set up Sentry in your Next.js application following the [installation guide](/platforms/javascript/guides/nextjs/), you'll need to configure Wrangler with the required compatibility settings. | |
| Once you've set up Sentry in your Next.js application following the [installation guide](/platforms/javascript/guides/nextjs/), you'll need to configure [Wrangler](https://developers.cloudflare.com/workers/wrangler/) with the required compatibility settings. |
There was a problem hiding this comment.
Whoops. I've overlooked this one. I'll add it in a new PR
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR This is just adding the suggestion of #16224 (comment) ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
DESCRIBE YOUR PR
The document existed in Nextjs but from Cloudflare there was no way to know you can deploy Nextjs on cloudflare. I now moved the docs to the Cloudflare section, but kept the page in Nextjs with a backlink.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES