Add the 0.0.0.0 address to the proxy configuration #16230
Conversation
- This is the default socket bind address for multiple services (like relay, symbolicator, etc). - When http(s)_proxy is set, health checks have issues for some people (like Backend Unreachable, etc). - Health checks for those services are not integrated into the service itself - they're separate processes that connect to the running service over HTTP. - The health check process queries the service instance address from the config. - Which defaults to something like `0.0.0.0:3000`. - Which is not in no_proxy. - So the health check process tries to access the service via the proxy - Which fails. - Which results in "Up 5 minutes (unhealthy)" despite the affected services working correctly. - Except that `docker compose up --wait` waits for all services to be healthy. So that fails too. - Also the `nginx` service depends on `web` (which works) and `relay` (which works, but reports itself as unhealthy), so the frontend never starts. And to fix all that, just add `0.0.0.0` to `noProxy` here and we're gucci.
|
@DragoonAethis is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
Let me ping @Dav1dde and @aldy505 since you reworked the health checks in relay and symbolicator - if you see issues around those two services, might be useful to ask if the affected setup has a proxy. |
|
I wonder if we were better off to just rewrite |
That could work too, AFAIK health checks are executed like |
Dav1dde
left a comment
Dav1dde
left a comment
There was a problem hiding this comment.
Tried to research this a bit, seems like there isn't an obvious reason why this may have unintended side-effects.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
3 participants
DESCRIBE YOUR PR
0.0.0.0is the default socket bind address for multiple services (like relay, symbolicator, etc) in their template configuration files.docker-compose.ymldefault to connecting to the service instance address from the service config.0.0.0.0:3000.docker compose up --waitwaits for all services to be healthy. So that fails too.nginxservice depends onweb(which works) andrelay(which works, but reports itself as unhealthy), so the frontend never starts.And to fix all that, just add
0.0.0.0tonoProxyhere and we're gucci.There are a couple of folks with weird health check issues on the self-hosted repo - it's likely they will benefit from this change too.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.