docs(astro,cloudflare): Update the guide to Astro on Cloudflare Workers#16545
docs(astro,cloudflare): Update the guide to Astro on Cloudflare Workers#16545
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| On Cloudflare Workers, you can also configure Sentry using [environment variables](https://developers.cloudflare.com/workers/configuration/environment-variables/). The SDK reads `SENTRY_DSN`, `SENTRY_TRACES_SAMPLE_RATE`, and other standard Sentry environment variables. | ||
|
|
||
| </Alert> |
There was a problem hiding this comment.
Updated cloudflare sections are now unreachable dead documentation
Low Severity
The PlatformSection supported={["javascript.cloudflare"]} blocks in this file were updated but are now unreachable. The only page that rendered them — docs/platforms/javascript/guides/cloudflare/frameworks/astro.mdx — no longer includes getting-started-complete (its PlatformContent include was removed in this same PR). The main Astro page at docs/platforms/javascript/guides/astro/index.mdx uses platform javascript.astro, so these cloudflare-gated sections are never shown. These updated sections are dead documentation that could cause confusion during future maintenance.
Additional Locations (1)
| } | ||
| ``` | ||
|
|
||
| Deploy your app and trigger both errors. Check your [Sentry project](https://sentry.io) to verify the errors appear. |
There was a problem hiding this comment.
Just had a quick look at your updates -> I noticed that the Sandbox warning/alert, the Tracing verification section (when the Tracing checkbox is enabled), and the "View Captured Data in Sentry" section were removed. See here: https://docs.sentry.dev/platforms/javascript/guides/astro/#tracing
Was that intentional? -> just wanted to double-check in case they were dropped by accident :)
|
|
||
| If you're using Cloudflare Pages (not Workers), expand the section below for | ||
| setup instructions. We recommend migrating to Cloudflare Workers for better | ||
| Sentry integration and full feature support. |
There was a problem hiding this comment.
q: Shouldn't this paragraph be outside of the Expandable?
3 participants
DESCRIBE YOUR PR
closes #16429
It is basically soft deprecating support for Cloudflare Pages and makes deploying to Cloudflare Workers more prominent.
Important: This should not be merged until v10.40.0 has been released.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES