docs(sdk): Rewrite Review and CI spec for readability#17018
Merged
stephanie-anderson merged 11 commits intomasterfrom Mar 18, 2026
Merged
docs(sdk): Rewrite Review and CI spec for readability#17018stephanie-anderson merged 11 commits intomasterfrom
stephanie-anderson merged 11 commits intomasterfrom
Conversation
Replace rigid Rule/Enforcement/Per-SDK override template with natural prose. Merge reviewers, SLAs, and feedback conventions into one code review section. Remove enforcement boilerplate and StatusBadge components. Move commit message validation to recommended CI checks. Promote spec status to stable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Update playbook links to match new section IDs after spec rewrite. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dingsdax
reviewed
Mar 18, 2026
dingsdax
reviewed
Mar 18, 2026
dingsdax
requested changes
Mar 18, 2026
Contributor
dingsdax
left a comment
dingsdax
left a comment
There was a problem hiding this comment.
secret scanning may sound optional, unsure about Warden being worth a separate section in a standard, playbook for sure
Co-authored-by: Stephanie Anderson <stephanie.anderson@sentry.io>
Rewrites the API and Architecture standards page to be more human-friendly: - Add intro paragraph framing the core philosophy - Replace rigid Rule/Enforcement/Per-SDK override template with natural prose - Merge breaking changes and deprecation lifecycle into one cohesive section - Remove enforcement boilerplate and StatusBadge components - Add contextual "why" before rules instead of dropping straight into requirements - Thin out RFC keyword density — keep MUST/REQUIRES for hard rules, plain language elsewhere - Promote spec status to stable --------- Co-authored-by: Claude <noreply@anthropic.com>
We've recently added a bunch of changes to Expo integrations in the React Native SDK, this PR adds the missing information about those changes to the docs. Here is the list of PRs it covers: - Expo Updates - getsentry/sentry-react-native#5794 - getsentry/sentry-react-native#5788 - getsentry/sentry-react-native#5748 - Expo Config Plugin - getsentry/sentry-react-native#5796 — 06d4e245 — Add environment option to Expo config plugin - EAS Build Integration - getsentry/sentry-react-native#5666 - getsentry/sentry-react-native#5773 - getsentry/sentry-react-native#5617 - Expo Router / Tracing - getsentry/sentry-react-native#5606 - getsentry/sentry-react-native#5718 - Tooling / Fixes - getsentry/sentry-react-native#5636 - getsentry/sentry-react-native#5733
…17019) Rewrites the Repository and Documentation standards page to be more human-friendly: - Add intro paragraph framing the purpose - Merge AGENTS.md, CONTRIBUTING.md, and PR template into one "Required repository files" section - Merge AI context maintenance and AI skills into one "AI context files" section - Add links to dotagents repo and documentation - Replace rigid Rule/Enforcement/Per-SDK override template with natural prose - Remove enforcement boilerplate, StatusBadge components, and suggested skills - Promote spec status to stable --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ecs (#17020) Rewrites both standards pages to be more human-friendly: **Coordination and Maintenance:** - Add intro paragraph - Merge triaging SLA and waiting-for labels into one "Issue triage" section - Merge post-release monitoring and rollback into "Post-release monitoring and regression handling", reframe rollback as regression handling **Release and Versioning:** - Add intro paragraph - Merge version format, pre-release identifiers, and build identifiers into one "Versioning" section - Merge release tooling, merge target, and multiple craft configs into one "Release tooling" section - Add cross-reference to post-release monitoring **Both pages:** - Replace rigid Rule/Enforcement/Per-SDK override template with natural prose - Remove enforcement boilerplate, StatusBadge components, and suggested skills - Promote spec status to stable --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Johannes Daxböck <johannes.daxboeck@sentry.io>
Rewrites the Code Quality standards page to be more human-friendly: - Add intro paragraph framing the purpose - Merge linting + type checking into one section - Merge test requirements + test quality into one section with subheadings - Replace rigid Rule/Enforcement/Per-SDK override template with natural prose - Remove enforcement boilerplate, StatusBadge components, and suggested skills - Remove vulnerability patch SLAs - Promote spec status to stable Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…w-ci-spec # Conflicts: # develop-docs/sdk/getting-started/playbooks/development/handling-a-regression.mdx # develop-docs/sdk/getting-started/playbooks/development/opening-a-pr.mdx # develop-docs/sdk/getting-started/playbooks/development/reviewing-a-pr.mdx # develop-docs/sdk/getting-started/playbooks/development/reviewing-ai-generated-code.mdx # develop-docs/sdk/getting-started/playbooks/sdk-lifecycle/cutting-a-release.mdx # develop-docs/sdk/getting-started/playbooks/setup/setting-up-new-sdk-repo.mdx # develop-docs/sdk/getting-started/playbooks/setup/setting-up-release-infrastructure.mdx # develop-docs/sdk/getting-started/standards/review-ci.mdx
dingsdax
approved these changes
Mar 18, 2026
constantinius
pushed a commit
that referenced
this pull request
Mar 20, 2026
Rewrites the Review and CI standards page to be more human-friendly: - Add intro paragraph framing the purpose - Merge reviewers, review SLAs, and feedback conventions into one cohesive "Code review" section - Move commit message validation from required to recommended CI checks - Replace rigid Rule/Enforcement/Per-SDK override template with natural prose - Remove enforcement boilerplate, StatusBadge components, and suggested skills - Promote spec status to stable --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the Review and CI standards page to be more human-friendly: