Skip to content

Bump API schema to 4c69fc3e#17338

Merged
sentry-api-schema-updater[bot] merged 1 commit intomasterfrom
bot/bump-api-schema-to-4c69fc3e
Apr 14, 2026
Merged

Bump API schema to 4c69fc3e#17338
sentry-api-schema-updater[bot] merged 1 commit intomasterfrom
bot/bump-api-schema-to-4c69fc3e

Conversation

@sentry-api-schema-updater
Copy link
Copy Markdown
Contributor

No description provided.

@sentry-api-schema-updater sentry-api-schema-updater bot merged commit 178d730 into master Apr 14, 2026
@sentry-api-schema-updater sentry-api-schema-updater bot deleted the bot/bump-api-schema-to-4c69fc3e branch April 14, 2026 14:52
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Apr 14, 2026 3:03pm
sentry-docs Ready Ready Preview, Comment Apr 14, 2026 3:03pm

Request Review

// SENTRY_API_SCHEMA_SHA is used in the sentry-docs GHA workflow in getsentry/sentry-api-schema.
// DO NOT change variable name unless you change it in the sentry-docs GHA workflow in getsentry/sentry-api-schema.
const SENTRY_API_SCHEMA_SHA = '4e1fa24c45cd047a0e1ccbea41faa1a706026be8';
const SENTRY_API_SCHEMA_SHA = '4c69fc3e332668b6480c78a9a7cdf0c417ddd317';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The resolveOpenAPI function lacks error handling for its fetch call to GitHub, which can lead to unhandled promise rejections and crash the build process.
Severity: HIGH

Suggested Fix

Wrap the fetch call and the response.json() invocation in a try-catch block. Additionally, check the response.ok property to ensure the HTTP request was successful before attempting to parse the body as JSON. If an error occurs, log it and handle it gracefully to prevent the application from crashing.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/build/resolveOpenAPI.ts#L9

Potential issue: The `resolveOpenAPI` function fetches an OpenAPI schema from GitHub
without handling potential network errors or non-200 HTTP responses. If the fetch fails
due to a network timeout, a GitHub service issue (e.g., 503 error), or another non-200
response, the subsequent call to `response.json()` will throw an unhandled promise
rejection. Because this function is called during the static build process via
`generateStaticParams`, such a failure will crash the entire build. It can also cause
runtime failures when accessing API pages.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants