Skip to content

feat(a11y): Add skip-to-content accessibility link#17527

Merged
rahulchhabria merged 3 commits intomasterfrom
macuzi/feat/skip-to-content
Apr 29, 2026
Merged

feat(a11y): Add skip-to-content accessibility link#17527
rahulchhabria merged 3 commits intomasterfrom
macuzi/feat/skip-to-content

Conversation

@rahulchhabria
Copy link
Copy Markdown
Contributor

DESCRIBE YOUR PR

Adds a root-level skip-to-content link and ensures non-DocPage routes have a matching #main target. This keeps keyboard users from getting stuck on the home page or 404 page when using the skip link.

This replaces fork PR #17479 so the Codeowner assignment workflow can run with same-repo permissions.

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you have added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

macuzi and others added 3 commits April 25, 2026 12:13
Add a keyboard-accessible "Skip to content" link that appears on Tab
focus and jumps to the main content area. Resets focus navigation on
client-side route changes so the link remains the first Tab stop.
Add matching #main targets to the home and 404 pages so the root skip link works outside DocPage-rendered routes. Remove the unused skip-link anchor ref.
Merge origin/master into the skip-to-content branch. Keep the incoming home page card updates while preserving the #main target needed by the skip link.
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Apr 29, 2026 4:48am
sentry-docs Ready Ready Preview, Comment Apr 29, 2026 4:48am

Request Review

@rahulchhabria rahulchhabria marked this pull request as ready for review April 29, 2026 04:36
@rahulchhabria
Copy link
Copy Markdown
Contributor Author

@macuzi - this should be good to go. can you give it a review pls?

@sfanahata -- i might need you to stamp it too

Copy link
Copy Markdown
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding this.

@macuzi
Copy link
Copy Markdown
Contributor

macuzi commented Apr 29, 2026

Looks good! Tested locally — skip-to-content works well on docs pages.

Minor questions/notes for potential future iteration:

  • On /platforms, the search input autofocuses so it grabs focus before the skip link. Could be intentional since in theory we want the user to select a platform beforehand?
  • On the home page, there's no <div id="main"> like doc pages have — so we could potentially omit this for the home page?

Neither is a blocker and looks great, approving! Thanks for the assistance 🙂

@sfanahata
Copy link
Copy Markdown
Contributor

sfanahata commented Apr 29, 2026

Looks good! Tested locally — skip-to-content works well on docs pages.

Minor notes for future iteration:

  • On /platforms, the search input autofocuses so it grabs focus before the skip link. Could be intentional since in theory we want the user to select a platform beforehand?
  • On the home page, there's no <div id="main"> like doc pages have — so we could potentially omit this for the home page?

Neither is a blocker and looks great, approving! Thanks for the assistance 🙂

Honestly, I think there is definitely more we can do about tabbing through the site, but chewing on what would be best to improve after this. One annoying factor is the left nav losing focus after selecting a page. Not sure there's much we can do, but I might look into it.

Looks like that /platforms experience is just for when you first land and haven't already selected an SDK. I would agree that we generally want someone to get to the platform they're interested in, rather then skipping to the body for the platforms index page, so would suggest leaving it as is.

@macuzi
Copy link
Copy Markdown
Contributor

macuzi commented Apr 29, 2026

Agreed on both fronts @sfanahata 🙂

Copy link
Copy Markdown
Contributor

@macuzi macuzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rahulchhabria rahulchhabria merged commit da9cd11 into master Apr 29, 2026
31 of 36 checks passed
@rahulchhabria rahulchhabria deleted the macuzi/feat/skip-to-content branch April 29, 2026 17:25
cameroncooke pushed a commit that referenced this pull request Apr 30, 2026
## DESCRIBE YOUR PR
Adds a root-level skip-to-content link and ensures non-DocPage routes
have a matching `#main` target. This keeps keyboard users from getting
stuck on the home page or 404 page when using the skip link.

This replaces fork PR #17479 so the Codeowner assignment workflow can
run with same-repo permissions.

## IS YOUR CHANGE URGENT?  

- [ ] Urgent deadline (GA date, etc.):
- [ ] Other deadline:
- [x] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you
have added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

- [ ] Checked Vercel preview for correctness, including links
- [x] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

---------

Co-authored-by: macuzi <lamberto.asghedom@sentry.io>
coolguyzone pushed a commit that referenced this pull request May 1, 2026
## DESCRIBE YOUR PR
Adds a root-level skip-to-content link and ensures non-DocPage routes
have a matching `#main` target. This keeps keyboard users from getting
stuck on the home page or 404 page when using the skip link.

This replaces fork PR #17479 so the Codeowner assignment workflow can
run with same-repo permissions.

## IS YOUR CHANGE URGENT?  

- [ ] Urgent deadline (GA date, etc.):
- [ ] Other deadline:
- [x] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you
have added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

- [ ] Checked Vercel preview for correctness, including links
- [x] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

---------

Co-authored-by: macuzi <lamberto.asghedom@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants