feat(a11y): Add skip-to-content accessibility link#17527
feat(a11y): Add skip-to-content accessibility link#17527rahulchhabria merged 3 commits intomasterfrom
Conversation
Add a keyboard-accessible "Skip to content" link that appears on Tab focus and jumps to the main content area. Resets focus navigation on client-side route changes so the link remains the first Tab stop.
Add matching #main targets to the home and 404 pages so the root skip link works outside DocPage-rendered routes. Remove the unused skip-link anchor ref.
Merge origin/master into the skip-to-content branch. Keep the incoming home page card updates while preserving the #main target needed by the skip link.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@macuzi - this should be good to go. can you give it a review pls? @sfanahata -- i might need you to stamp it too |
sfanahata
left a comment
There was a problem hiding this comment.
Looks good! Thanks for adding this.
|
Looks good! Tested locally — skip-to-content works well on docs pages. Minor questions/notes for potential future iteration:
Neither is a blocker and looks great, approving! Thanks for the assistance 🙂 |
Honestly, I think there is definitely more we can do about tabbing through the site, but chewing on what would be best to improve after this. One annoying factor is the left nav losing focus after selecting a page. Not sure there's much we can do, but I might look into it. Looks like that |
|
Agreed on both fronts @sfanahata 🙂 |
## DESCRIBE YOUR PR Adds a root-level skip-to-content link and ensures non-DocPage routes have a matching `#main` target. This keeps keyboard users from getting stuck on the home page or 404 page when using the skip link. This replaces fork PR #17479 so the Codeowner assignment workflow can run with same-repo permissions. ## IS YOUR CHANGE URGENT? - [ ] Urgent deadline (GA date, etc.): - [ ] Other deadline: - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you have added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [x] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: macuzi <lamberto.asghedom@sentry.io>
## DESCRIBE YOUR PR Adds a root-level skip-to-content link and ensures non-DocPage routes have a matching `#main` target. This keeps keyboard users from getting stuck on the home page or 404 page when using the skip link. This replaces fork PR #17479 so the Codeowner assignment workflow can run with same-repo permissions. ## IS YOUR CHANGE URGENT? - [ ] Urgent deadline (GA date, etc.): - [ ] Other deadline: - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you have added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [x] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: macuzi <lamberto.asghedom@sentry.io>
DESCRIBE YOUR PR
Adds a root-level skip-to-content link and ensures non-DocPage routes have a matching
#maintarget. This keeps keyboard users from getting stuck on the home page or 404 page when using the skip link.This replaces fork PR #17479 so the Codeowner assignment workflow can run with same-repo permissions.
IS YOUR CHANGE URGENT?
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST