Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/docPage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export async function DocPage({
<div
className={[
'pt-6 px-6 prose dark:prose-invert max-w-full text-[var(--gray-12)] prose-a:no-underline hover:prose-a:underline',
'prose-code:font-normal prose-code:font-mono marker:text-[var(--accent)] prose-li:my-1',
'prose-code:font-normal prose-code:font-mono marker:text-[var(--darkPurple)] marker:font-medium prose-li:my-1',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The list marker font weight is set to marker:font-medium instead of the intended marker:font-normal, contradicting the PR's goal.
Severity: LOW

Suggested Fix

Change the class marker:font-medium to marker:font-normal at src/components/docPage/index.tsx:93 to align the list marker font weight with the intended design as specified in the PR description.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/components/docPage/index.tsx#L93

Potential issue: The code at `src/components/docPage/index.tsx:93` applies the
`marker:font-medium` Tailwind CSS class, resulting in a font weight of 500 for list
markers. However, the pull request description and a specific commit message
(`685eb6d1`) explicitly state the intention was to use `marker:font-normal` (font weight
400) to match a design mockup. The final committed code appears to have accidentally
retained the incorrect `font-medium` class, leading to a visual inconsistency with the
intended design.

Did we get this right? 👍 / 👎 to inform future reviews.

'prose-headings:mt-0 prose-headings:font-medium prose-headings:relative prose-headings:text-[var(--gray-12)]',
'prose-blockquote:font-normal prose-blockquote:border-l-[3px] prose-em:font-normal prose-blockquote:text-[var(--gray-12)]',
'prose-img:my-2',
Expand Down
Loading