-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: match list markers to heading color instead of accent #17740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1
−1
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e23fccd
fix: match list markers to heading color instead of accent
ee8ba34
fix: add font-weight:400 to list markers to match mockups
7f27d43
fix: update list marker font-weight to 500
685eb6d
fix(docs): Use normal font weight for list markers
cursoragent dee8d02
Change marker font style in docPage component
coolguyzone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The list marker font weight is set to
marker:font-mediuminstead of the intendedmarker:font-normal, contradicting the PR's goal.Severity: LOW
Suggested Fix
Change the class
marker:font-mediumtomarker:font-normalatsrc/components/docPage/index.tsx:93to align the list marker font weight with the intended design as specified in the PR description.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.