fix(react-native): Remove broken includeWebFeedback option from Metro docs#17774
Merged
Conversation
The `includeWebFeedback: false` option causes a crash at startup because `@sentry/browser` calls `buildFeedbackIntegration()` from `@sentry-internal/feedback` at module evaluation time. Unlike replay, which is a plain re-export, stubbing the feedback package to empty makes the function undefined, causing: TypeError: buildFeedbackIntegration is not a function Removing from docs until the SDK fix lands. Fixes getsentry/sentry-react-native#6149 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Removes
includeWebFeedback: falsefrom the "Reduce Bundle Size" Metro config examples and the options table.The
includeWebFeedback: falseoption causes a crash at app startup:Root cause: When the option stubs
@sentry-internal/feedbackto an empty module,@sentry/browser's barrel file still importsfeedbackSync.jsandfeedbackAsync.js, which callbuildFeedbackIntegration()at module evaluation time. Unlike@sentry-internal/replay(which is just re-exported without being called), the feedback package has intermediate wrapper files that eagerly invoke the stubbed export.This is a temporary docs fix until the SDK-side fix lands in
sentry-react-native.Fixes getsentry/sentry-react-native#6149
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST