Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/integrations/source-code-mgmt/github/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,11 @@ Occasionally, Sentry will request additional permissions to your GitHub account
</tr>
<tr>
<th>Webhook URL </th>
<td>https://sentry.io/extensions/github-enterprise/webhook/ </td>
<td>
https://sentry.io/extensions/github-enterprise/webhook/
<br />
<small>If you're configuring a custom GitHub App on github.com (instead of GitHub Enterprise Server or GitHub Enterprise Cloud), use `https://sentry.io/extensions/github-enterprise/webhook/github-com/` instead.</small>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnt-sentry I'm getting a 404 on this external link.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gives me a 400 which is expected if you navigate to it in your browser. It is meant to be used in the github app configuration. If you are getting a 400 and not 404 then its behaving properly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good to know. Is it worth noting that this URL only works as a part of the integration config? I can't tell whether I should care about the functionality of those URLs from the current instructions.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image The url is presented as part of a form of things to copy paste into the github app creation. With that context, I think it is fine as is.

</td>
</tr>
<tr>
<th>Webhook secret </th>
Expand Down
Loading