js(docs): Update Tracing pages for stream mode#17862
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…an-first/js-tracing-updates
inventarSarah
requested review from
Lms24,
aniruddhacharya-glitch,
chargome,
cleptric,
mydea and
sfanahata
and removed request for
aniruddhacharya-glitch
| }); | ||
| ``` | ||
|
|
||
| ```javascript {tabTitle:Stream Mode} |
There was a problem hiding this comment.
I'm liking these additions!
|
|
||
| See <PlatformLink to="/tracing/new-spans/">New Spans</PlatformLink> for more information. | ||
|
|
||
| ## `ignoreSpans` Rules No Longer Work After Migrating to Stream Mode |
There was a problem hiding this comment.
Do they no longer work, or does the behavior change?
There was a problem hiding this comment.
Updated this to "... No Longer Work As Expected After Migrating ..."
There was a problem hiding this comment.
I guess I'm still not entirely clear what that means. Does it just not work, or will it still work but differently? We should be explicit.
There was a problem hiding this comment.
I updated the description in this section to be more specific.
The title is fitting imo though -- for some users it could not work at all, for others some spans get dropped correctly and some not -- it depends on their configuration
…an-first/js-tracing-updates
Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
…try/sentry-docs into smi/span-first/js-tracing-updates
| }); | ||
| ``` | ||
|
|
||
| ```javascript {tabTitle:Stream Mode} |
…an-first/js-tracing-updates
3 participants
DESCRIBE YOUR PR
This branch contains light edits to the JavaScript Tracing pages, mentioning the New Spans and Stream Mode as needed.
Important
Must only be merged after #17834
This branch is separate from this PR and thus does not contain the new /tracing/new-spans page. However, this branch adds links to that page, which the 404 Linter identifies correctly as broken
Closes: #17836
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES