Conversation
ehfeng
approved these changes
Aug 3, 2018
Contributor
ehfeng
left a comment
ehfeng
left a comment
There was a problem hiding this comment.
We should wait on https://github.com/getsentry/getsentry/pull/2093 being merged before merging this.
MeredithAnya
reviewed
Aug 3, 2018
| ~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| It's important to note that spike protection is not meant to help you **manage your event volume** | ||
| because it is a moving target. To control event volume, you should rate limit by projects or use |
Member
There was a problem hiding this comment.
Are you talking about per-project rate limits here? If so, is it worth mentioning if it's only available on Large
Should address the plan comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted from #277